Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup build flags, global namespace and includes #1841

Merged
merged 14 commits into from
Apr 23, 2024
Merged

Cleanup build flags, global namespace and includes #1841

merged 14 commits into from
Apr 23, 2024

Commits on Apr 19, 2024

  1. Cleanup build flags, global namespace and includes 

    - Separated displays so they don't have to be all built even when the
  features are disabled.
- Removed weird linker magic for display init and replaced it with
  straightforward (and faster) template functions that behave the same.
  - Replaced disabled_display_output classes with log messages.
- Add explicit errors when feature dependent headers get included where
  they shouldn't.
- Use gperf to build perfect hash for color names instead of custom X11
  lookup. This should make it easier to add more color names to the list
  with no extra cost.
- Made alignment use a specific bit layout which greatly simplifies
  code.
- Switch BUILD_MOUSE_EVENTS dependency from OWN_WINDOW to BUILD_X11.
- Other minor improvements to some existing code which shouldn't affect
  behavior.
- Add documentation links to sample configs.

Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
    @Caellian
    Caellian committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    c23afeb View commit details
    Browse the repository at this point in the history

  2. Disable mouse tracking if BUILD_MOUSE_EVENTS=off 

    Fix missing Colour construct alpha argument.

Add Makefile ignore to 3rdparty/toluapp

Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
    @Caellian
    Caellian committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    a04f133 View commit details
    Browse the repository at this point in the history

  3. Fix tests 

    Swapped parse_color_name return values as they were the wrong way around
previously. Passing name parsing tests now.

Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
    @Caellian
    Caellian committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    17e3def View commit details
    Browse the repository at this point in the history

  4. Remove imlib setting from x11-settings 

    Registration ordering is controlled by `settings_ordering` now.

Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
    @Caellian
    Caellian committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    3df161d View commit details
    Browse the repository at this point in the history

  5. Fix set_struts switch 

    Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
    @Caellian
    Caellian committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    313a5f7 View commit details
    Browse the repository at this point in the history

  6. Revert "Remove imlib setting from x11-settings" 

    This reverts commit 3df161d.
    @Caellian
    Caellian committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    8ec80d7 View commit details
    Browse the repository at this point in the history

  7. Revert color perfect hash name parsing 

    Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
    @Caellian
    Caellian committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    a2fa80f View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. Revert set_struts changes 

    Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
    @Caellian
    Caellian committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    dc8b241 View commit details
    Browse the repository at this point in the history

  2. Remove unneeded guards 

    Display files are now no longer compiled if their features are disabled

Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
    @Caellian
    Caellian committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    c809867 View commit details
    Browse the repository at this point in the history

  3. Remove X11 from unrelated headers 

    This reaches 0% unneeded X11 polution in the sources.

Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
    @Caellian
    Caellian committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    7c4fea5 View commit details
    Browse the repository at this point in the history

  4. Reenabled parts of window_type which would work in Wayland 

    Added documentation for it.

Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
    @Caellian
    Caellian committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    c69dcaf View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Move dpi_scale to display-output.hh 

    Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
    @Caellian
    Caellian committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    3093cdd View commit details
    Browse the repository at this point in the history

  2. Move saved_coordinates to imlib 

    Hide lua state from conky-imlib2.cc

Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
    @Caellian
    Caellian committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    8e07629 View commit details
    Browse the repository at this point in the history

  3. Update docs 

    Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
    @Caellian
    Caellian committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    d23c117 View commit details
    Browse the repository at this point in the history