Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move color parse error message out of hex parser #1937

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Caellian
Copy link
Collaborator

@Caellian Caellian commented May 25, 2024

Gives a better error message if no parsers (possibly more in future) can parse the color.

This avoids issues like getting a misleading error message when color name parsing didn't work.

I'm making this change until I'm done with logging improvements (a few tweaks left, but not sure when I'll be able to clean up the code).

Simplifies parsing code, gives a better message and reduces responsibility of
last parser to report errors.

Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@github-actions github-actions bot added the sources PR modifies project sources label May 25, 2024
Copy link

netlify bot commented May 25, 2024

Deploy Preview for conkyweb canceled.

Name Link
🔨 Latest commit 171b961
🔍 Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/66524726eb2604000834cbba

Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@Caellian Caellian changed the title Move color parse message out of hex parser Move color parse error message out of hex parser May 25, 2024
Make ctest print output on failure.

Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@github-actions github-actions bot added the gh-actions Issue or PR that suggest changing GitHub actions label May 25, 2024
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@Caellian
Copy link
Collaborator Author

The test seems to be failing because it now catches an error in scan_graph argument parser. I'll fix that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gh-actions Issue or PR that suggest changing GitHub actions sources PR modifies project sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants