Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AJ-422: migrate raven-logback -> sentry-logback #1256

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

davidangb
Copy link
Contributor

@davidangb davidangb commented Dec 8, 2023

See https://broadworkbench.atlassian.net/browse/AJ-422 for context - this upgrades an obsolete library to current.

Have you read CONTRIBUTING.md lately? If not, do that first.

I, the developer opening this PR, do solemnly pinky swear that:

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've updated the RC_XXX release ticket with any manual steps required to release this change
  • I've updated the FISMA documentation if I've made any security-related changes, including auth, encryption, or auditing

In all cases:

  • Get two thumbsworth of review and PO signoff if necessary
  • Verify all tests go green
  • Squash and merge; you can delete your branch after this unless it's for a hotfix. In that case, don't delete it!
  • Test this change deployed correctly and works on dev environment after deployment

@davidangb
Copy link
Contributor Author

Jenkins retest

@davidangb
Copy link
Contributor Author

argo error in fiab-start; Jenkins retest

Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (99e4655) 69.34% compared to head (c13ee91) 69.34%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1256   +/-   ##
========================================
  Coverage    69.34%   69.34%           
========================================
  Files           97       97           
  Lines         3402     3402           
  Branches       372      372           
========================================
  Hits          2359     2359           
  Misses        1043     1043           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidangb davidangb merged commit 896aba6 into develop Dec 11, 2023
7 checks passed
@davidangb davidangb deleted the da_AJ-422_updateSentry branch December 11, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants