Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to only push to dev when merging to dev, update workflow-dispa… #1265

Merged
merged 6 commits into from
Dec 18, 2023

Conversation

jyang-broad
Copy link
Contributor

@jyang-broad jyang-broad commented Dec 18, 2023

switch to only push to dev when merging to dev, update workflow-dispatch to report test results

<your comments for this PR go here>

Have you read CONTRIBUTING.md lately? If not, do that first.

I, the developer opening this PR, do solemnly pinky swear that:

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've updated the RC_XXX release ticket with any manual steps required to release this change
  • I've updated the FISMA documentation if I've made any security-related changes, including auth, encryption, or auditing

In all cases:

  • Get two thumbsworth of review and PO signoff if necessary
  • Verify all tests go green
  • Squash and merge; you can delete your branch after this unless it's for a hotfix. In that case, don't delete it!
  • Test this change deployed correctly and works on dev environment after deployment

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b5e9993) 69.34% compared to head (51f82de) 69.34%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1265   +/-   ##
========================================
  Coverage    69.34%   69.34%           
========================================
  Files           97       97           
  Lines         3402     3402           
  Branches       372      372           
========================================
  Hits          2359     2359           
  Misses        1043     1043           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@davidangb davidangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@jyang-broad jyang-broad merged commit 9e23709 into develop Dec 18, 2023
15 checks passed
@jyang-broad jyang-broad deleted the DDO-3389-fix-orch-ci branch December 18, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants