Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change filter_by_csqs to filter_by_consequence_category and clean it up and use gnomad_methods function #10

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

jkgoodrich
Copy link
Contributor

Relies on broadinstitute/gnomad_methods#748

Need to resolve the TODO, but wanted to discuss before looking into it since @KoalaQin might already have the answer

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jkgoodrich jkgoodrich changed the base branch from main to development December 20, 2024 00:45
Copy link

@KoalaQin KoalaQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except a tiny thing.


- synonymous_variant

`Other

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`Other
Other

@jkgoodrich jkgoodrich merged commit 91ecb7d into development Dec 20, 2024
2 checks passed
@jkgoodrich jkgoodrich deleted the jg/update_filter_by_csqs branch December 20, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants