-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First draft of Toolbox use cases #4
Conversation
this file is needed to create a python package with this repo, right? so we would want to keep it |
I will try to solve the cluster issue when it circles back. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
- Add a description of the repo structure to the README - Add some potential requirements - Update the documentation and make sure it works - Create a notebook specific to loading gnomAD release data and just showing what each dataset looks like.
- Add a description of the repo structure to the README - Add some potential requirements - Update the documentation and make sure it works - Create a notebook specific to loading gnomAD release data and just showing what each dataset looks like.
- Addition of variant.py to store some functions that can also be used by frequency based filtering - Changes to frequency filtering to use new default settings if not passed a ht
Co-authored-by: Qin He <44242118+KoalaQin@users.noreply.github.com>
Suggestions on the initial toolbox PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm for the development branch
This PR includes the following examples:
Get variant count
Filter to variants by VEP annotations
Get 'freq' for specific genetic ancestry groups
I also removed the "setup.py" because it caused problems while starting a cluster, we have 'setup.py' in gnomad_methods, but we don't have it in gnomad_qc, do we really need it here?