Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gnomad_methods variant parser #8

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

jkgoodrich
Copy link
Contributor

Also added a fix to the setup.py and a TODO to the requirements

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@KoalaQin
Copy link

Wait, merge to development, right?

@jkgoodrich jkgoodrich changed the base branch from main to development December 19, 2024 18:48
Copy link

@KoalaQin KoalaQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Small question: why did you remove the . in setup.py?

@jkgoodrich
Copy link
Contributor Author

Small question: why did you remove the . in setup.py?

So that it will add load_data.py when building and installing

@jkgoodrich jkgoodrich merged commit 0350630 into development Dec 20, 2024
2 checks passed
@jkgoodrich jkgoodrich deleted the jg/use_gnomad_methods_variant_parser branch December 20, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants