Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JN-1523] preserving study sidebar during portal navigation #1305

Merged
merged 7 commits into from
Dec 12, 2024

Conversation

devonbush
Copy link
Collaborator

DESCRIPTION (include screenshots, and mobile screenshots for participant UX)

Updates the portal dashboard to auto-select a study so that we can always have the study sidebar available. Also changes some sidebar links so the study context is preserved while, e.g., navigating to edit the portal

TO TEST: (simple manual steps for confirming core behavior -- used for pre-release checks)

  1. go to https://localhost:3000/
  2. select a portal
  3. observe the full study sidebar now appears
  4. click on Design -> Website
  5. observe that the study context is preserved
  6. go back to the portal dashboard
  7. click on "Manage" links in the widgets. Confirm study context is preserved

Copy link
Member

@MatthewBemis MatthewBemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pr is such a relief 🎉

Copy link
Collaborator

@connorlbark connorlbark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -120,6 +124,12 @@ export const StudySidebar = ({ study, portalList, portalShortcode }:
className={sidebarNavLinkClasses} style={navStyleFunc}>Site Settings</NavLink>
</li>
</ul>}/>
<CollapsableMenu header={'Manage'} content={<ul className="list-unstyled">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manage sounds generic to me but I can't think of anything I'm super in love with... Maybe the section could be called Study Staff and the page is Accounts?

(As an aside, right now Team members has a different casing than the rest of the sidebar)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, this section used to be called Administration before i removed it in the redesign

also good catch with the differing casing- looks like Mailing list differs too

@devonbush devonbush merged commit 360bdde into development Dec 12, 2024
18 checks passed
@devonbush devonbush deleted the db-sidebar-update branch December 12, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants