Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JN-1525] adds subject to participant list #1331

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

devonbush
Copy link
Collaborator

DESCRIPTION (include screenshots, and mobile screenshots for participant UX)

Adds subject to the participant list
image

This is hidden by default since it will only be useful for A-T and other studies with proxies

TO TEST: (simple manual steps for confirming core behavior -- used for pre-release checks)

  1. go to https://localhost:3000/demo/studies/heartdemo/env/sandbox/participants
  2. confirm 'subject' is not initially shown
  3. Add it from the column select, confirm it appears

Copy link
Collaborator

@connorlbark connorlbark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... So right now the backend doesn't load proxies at all for the participant list. By default it only loads subjects. I would find this UI confusing because this will always display no proxies unless someone also goes in and edits their advanced search filters as well as this column filter.

Perhaps we should remove that automatically added search filter and instead do the filtering in the frontend. That way this column filter will work as expected.

Alternatively, we could have this column filter control whether or not that filter gets added to the search expression sent to the backend.

@connorlbark connorlbark self-requested a review December 12, 2024 15:58
@devonbush
Copy link
Collaborator Author

agree with Connor's thought. We can go ahead and merge this PR to add the column, and then follow-up with a later PR to change the default filtering

@devonbush devonbush merged commit 955713b into development Dec 12, 2024
18 checks passed
@devonbush devonbush deleted the db-add-pl-subject branch December 12, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants