[JN-1453] Add freetext editor to survey question designer #1349
Conversation
|
Two things tripped me up when using it locally -- I didn't realize that the keyboard was a toggle -- it looked like a tab control. To make it clearer how to switch back, it would be nice to have the icon change (maybe a wand or something for the button to switch back). Then I was thrown that you couldn't switch to JSON view unless you had a stableId (or maybe it's that you can't go direct from typing mode to JSON mode?). This made me think I was trapped after typing in some stuff for a question. Might be nice to either enable the editor switch, or disable it with a note like "you must do to enter JSON mode" |
|
@devonbush thanks, that's great ux feedback. i'll rework this a bit. throwing into draft in the meantime |
| <IconButton icon={showFreetextMode ? faKeyboard : faWandMagicSparkles} | ||
| disabled={showJsonEditor} | ||
| aria-label={showFreetextMode ? 'Switch to designer' : 'Switch to freetext editor'} | ||
| onClick={() => setShowFreetextMode(!showFreetextMode)} | ||
| /> |
There was a problem hiding this comment.
There seemed to be some weirdness when I entered freetext mode in a panel where it didn't properly create a stableid and I ended up getting an error preventing me from saving.
There was a problem hiding this comment.
That's how it behaves with regular questions too. We could auto-generate a question stable id, but since it's an identifier for research/operational datasets I think we should force the user to type one out. Of course, always open to changing later if we hear that it's annoying users!
| rows={15} | ||
| onChange={value => { | ||
| setFreetext(value) | ||
| const newQuestionObj = questionFromRawText(value) |
There was a problem hiding this comment.
Huh, crazy that this function already existed!
MatthewBemis
force-pushed
the
mb-jn-1453-freetext
branch
from
ae0845f to
740a673
Compare
|
DESCRIPTION (include screenshots, and mobile screenshots for participant UX)
TO TEST: (simple manual steps for confirming core behavior -- used for pre-release checks)
Go to the survey designer: https://localhost:3000/demo/studies/heartdemo/env/sandbox/forms/surveys/hd_hd_basicInfo
Click the new freetext button
Enter in some text, ensuring it creates text and radio questions correctly