[JN-1416] Add language texts for 10 new languages #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewBemis
commented
Jan 6, 2025
| {"keyName": "navbarDashboard", "text": "Tablero", "language": "es"}, | ||
| {"keyName": "navbarChangePassword", "text": "Cambiar Contraseña", "language": "es"}, | ||
| {"keyName": "navbarLogout", "text": "Cerrar Sesión", "language": "es"}, | ||
| {"keyName": "navbarDashboard", "text": "Panel de control", "language": "es"}, |
There was a problem hiding this comment.
This file in particular is interesting to look at because it basically shows us Google Translate versus a professional translation service
MatthewBemis
changed the title
connorlbark
approved these changes
Jan 6, 2025
|
Yeah, that sounds like a reasonable test. I was surprised that we're now escaping |
devonbush
approved these changes
Jan 6, 2025
MatthewBemis
force-pushed
the
mb-jn-1416-language-texts
branch
from
5e37a66 to
ed03b48
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION (include screenshots, and mobile screenshots for participant UX)
Per LanguageScientific, this adds 10 new languages and updates our Spanish language texts.
TO TEST: (simple manual steps for confirming core behavior -- used for pre-release checks)
Restart AdminApiApp
Confirm language texts repopulate without error
select count(*) from language_text;should yield about 1800 rows