[JN-1551] checkboxes with multiple 'other' questions #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorlbark
commented
Jan 7, 2025
Comment on lines
-7
to
-10
| demoResponse=$(curl -s 'https://admin-d2p.ddp-dev.envs.broadinstitute.org/version') | ||
| demoResponse=$(curl -s 'https://juniper-cmi.dev/version') | ||
| demoGitTag=$(echo $demoResponse | jq -r '.gitTag') | ||
|
|
||
| prodResponse=$(curl -s 'https://juniper.terra.bio/version') |
connorlbark
commented
Jan 7, 2025
Comment on lines
+165
to
+172
| private static String nodeToString(JsonNode node) { | ||
| if (node.getNodeType().equals(JsonNodeType.STRING)) { | ||
| return node.asText(); | ||
| } else { | ||
| return node.toString(); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
another drive by fix - most of our survey question definitions were actually blank because if you pass a json object through the normal asText it will just be "" since it isn't 'text'. This was affecting all questions that were translated - now, the name will be, e.g. { "en": "Title", "es": ...
connorlbark
commented
Jan 7, 2025
| "name": "schools", | ||
| "type": "checkbox", | ||
| "title": "What schools did you attend?", | ||
| "renderAs": "checkbox-multiple-other", |
There was a problem hiding this comment.
Note: checkboxes are unchanged unless you include this
connorlbark
changed the title
…lti-detail-question
|
devonbush
approved these changes
Jan 8, 2025
MatthewBemis
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION (include screenshots, and mobile screenshots for participant UX)
By default, surveyjs only allows 1 other question per checkbox group. This PR adds the ability to make checkboxes that have multiple other questions attached, with different titles for each.
I'm not in love with this approach - it adds a new "magic" way to add questions to surveys that aren't really fully surveyjs questions but have their own stable id. But aside from some hacky things like creating separate questions elsewhere and somehow rendering them inside of another question's checkboxes, I felt like this was the most elegant solution with the caveat of some weirdness if you rely on surveyjs's question list.
TO TEST: (simple manual steps for confirming core behavior -- used for pre-release checks)