[JN-1560] fix missing trcc export fields #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devonbush
approved these changes
Jan 19, 2025
| @@ -77,7 +76,13 @@ private void generateAnswerItemFormatters( | |||
| )).values().stream().sorted(Comparator.comparingInt(a -> a.get(0).getExportOrder())).toList(); | |||
|
|
|||
| for (List<SurveyQuestionDefinition> questionVersions : questionDefsByStableId) { | |||
| SurveyQuestionDefinition mostRecent = questionVersions.get(0); | |||
|
|
|||
| Optional<SurveyQuestionDefinition> mostRecentOpt = getLatest(questionVersions); | |||
There was a problem hiding this comment.
Instead of doing this, I think it's cleaner to update the code above to sort the lists as they're made.
I think you can pass a second argument to groupingBy of a collector that sorts the sublists. See https://stackoverflow.com/questions/35872236/sorting-lists-after-groupingby
MatthewBemis
approved these changes
Jan 21, 2025
connorlbark
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION (include screenshots, and mobile screenshots for participant UX)
We weren't actually getting the latest survey question definition, and earlier versions of these questions were
htmlso it was skipping them on export.TO TEST: (simple manual steps for confirming core behavior -- used for pre-release checks)