BUG FIX: correct the flipped logic in is_workflow_config_valid

broadinstitute · Oct 9, 2023 · 4b82a84 · 4b82a84
1 parent 394bbcd
commit 4b82a84
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/lrmaCU/terra/submission/submission_utils.py b/src/lrmaCU/terra/submission/submission_utils.py
@@ -144,13 +144,13 @@ def is_workflow_config_valid(ns: str, ws: str, workflow_name: str,
                      f" Manual intervention needed.")
         raise FireCloudServerError(response.status_code, response.text)
 
-    invalid_config = False
+    config_is_valid = True
     jes = response.json()
     for k in ['extraInputs', 'invalidInputs', 'invalidOutputs', 'missingInputs']:
         if 0 != len(jes[k]):
-            invalid_config = True
+            config_is_valid = False
             break
-    return invalid_config
+    return config_is_valid
 
 
 def restore_workflow_config(ns: str, ws: str, workflow_name: str, old_config: dict,