ID-562 fixing deprecated command in github action #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins retest |
tlangs
approved these changes
Apr 18, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
tlangs
approved these changes
Apr 21, 2023
|
jenkins retest why not |
Shakespeared
approved these changes
May 10, 2023
| @@ -84,11 +86,6 @@ jobs: | |||
| - name: coursier-cache-action | |||
| uses: coursier/cache-action@v5 | |||
|
|
|||
| - name: Extract branch name | |||
| shell: bash | |||
| run: echo "##[set-output name=branch;]$(echo ${GITHUB_REF#refs/heads/})" | |||
There was a problem hiding this comment.
IIRC you were wondering about this, I didn't really find an explanation but I did see this exact code here FWIW https://github.com/orgs/community/discussions/35994#discussioncomment-3896937
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/ID-562
What:
Addresses Github Action Command deprecation: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Why:
<For your reviewers' sake, please describe in ~1 paragraph what the value of this PR is to our users or to ourselves.>
How:
<For your reviewers' sake, please describe in ~1 paragraph how this PR accomplishes its goal.>
<If the PR is big, please indicate where a reviewer should start reading it (i.e. which file or function).>
PR checklist