Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID-757 remove google group syncing testing from integration tests. #1163

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

jyang-broad
Copy link
Contributor

@jyang-broad jyang-broad commented Aug 21, 2023

Ticket:

What:

Removes an integration test that appears to test the addition and removal of admins from a group.

Why:

This test alone is 50% of the entire suit's time cost and has unclear goals. Is it testing that behaves as expected, or is it testing that google does that Sam thinks it does. (see Jira ticket for more info)

How:

We deleted the entire test.

PR checklist

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've filled out the Security Risk Assessment (requires Broad Internal network access) and attached the result to the JIRA ticket

@jyang-broad jyang-broad changed the title removed a test ID-757 remove google group syncing testing from integration tests. Aug 21, 2023
Copy link
Contributor

@tlangs tlangs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is that this covers some sort of functionality not covered by unit tests. Is there a unit test that tests this without the group sync? I definitely don't like that we're actually talking to google in this test. Maybe it could be converted to a test that moves out the google apis if there's not already a unit test.

@Ghost-in-a-Jar
Copy link
Contributor

@tlangs yeah we could mock out the actual calls to google and keep the tests, i dont think it would be too much extra work

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants