Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AJ-1369 verify pet token pact #1205

Merged
merged 4 commits into from
Oct 19, 2023
Merged

AJ-1369 verify pet token pact #1205

merged 4 commits into from
Oct 19, 2023

Conversation

calypsomatic
Copy link
Contributor

@calypsomatic calypsomatic commented Oct 12, 2023 •
edited
Loading

Ticket: AJ-1369

This PR adds provider verification to the consumer contract test added in DataBiosphere/terra-workspace-data-service#363.

@calypsomatic calypsomatic mentioned this pull request Oct 13, 2023
Merged
@calypsomatic calypsomatic changed the title pet token pact AJ-1369 verify pet token pact Oct 13, 2023
@calypsomatic calypsomatic marked this pull request as ready for review October 13, 2023 14:21
jladieu
jladieu approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@jladieu jladieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't exactly follow how this pact stuff ties together, but this all seems like legit scala to me....

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ichengchang
ichengchang approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@ichengchang ichengchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@calypsomatic calypsomatic merged commit a881098 into develop Oct 19, 2023
19 of 22 checks passed
@calypsomatic calypsomatic deleted the aj-1369-token-pact branch October 19, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichengchang ichengchang ichengchang approved these changes

@yuliadub yuliadub yuliadub approved these changes

@jladieu jladieu jladieu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calypsomatic @jladieu @yuliadub @ichengchang