[DR-3245] Include auth domain actions in TDR snapshot roles #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable users to read and/or update the auth domain of a snapshot depending on their role.
samanehsan
force-pushed
the
se/DR-3245-auth-domains-on-tdr-snapshots
branch
from
e5ed09b to
6deb972
Compare
Ghost-in-a-Jar
approved these changes
Oct 17, 2023
s-rubenstein
approved these changes
Oct 17, 2023
src/main/resources/reference.conf
Outdated
| description = "view the auth domain of the snapshot" | ||
| } | ||
| update_auth_domain = { | ||
| description = "update the groups in the auth domain of the snapshot" |
There was a problem hiding this comment.
Is there potentially multiple auth domains for a snapshot or is there only one? If there's only one, I think this comment could be better described as "Update the auth domain of the snapshot" rather than mentioning groups. Just because auth domains are by definition defined by groups.
There was a problem hiding this comment.
Each resource only has one auth domain: https://sam.dsde-dev.broadinstitute.org/#/Resources/getAuthDomainV2
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/DR-3245
What: Enable TDR users to read and/or update the auth domain of a snapshot depending on their role.
Why: TDR is adding the ability for users to add an auth domain to their snapshot (which will get registered with a
group-constraintpolicy in the Terra Policy Service) in order to enforce who is allowed to access the data when it gets exported to a Terra workspace.How: Updated reference.conf
datasnapshotconfigPR checklist