Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for deployment in Azure Government Cloud (Workbench-Libs) #1713

Merged
merged 7 commits into from
Dec 17, 2024

Conversation

bennettn4
Copy link
Contributor

@bennettn4 bennettn4 commented Dec 2, 2024

Part of large effort to add support for services to run in Azure Government cloud.

  • Added environment variable for AZURE_ENVIRONMENT

https://broadworkbench.atlassian.net/browse/TOAZ-372
See related pull requests here:
workbench-libs sam bpm wsm cromwell terra-helmfile

PR checklist

  • For each library you've modified here, decide whether it requires a major, minor, or no version bump. (Click here for guidance)

If you're doing a major or minor version bump to any libraries:

  • Bump the version in project/Settings.scala createVersion()
  • Update CHANGELOG.md for those libraries
  • I promise I used @deprecated instead of deleting code where possible

In all cases:

  • Replace the appropriate version hashes in README.md and the CHANGELOG.md for any libs you changed with TRAVIS-REPLACE-ME to auto-update the version string
  • Get two thumbsworth of PR review
  • Verify all tests go green (CI and coverage tests)
  • Squash commits and merge to develop
  • Delete branch after merge

@bennettn4 bennettn4 marked this pull request as ready for review December 10, 2024 16:20
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 24.44%. Comparing base (87d8637) to head (6b26bf8).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
.../dsde/workbench/azure/AzureEnvironmentConfig.scala 0.00% 7 Missing ⚠️
.../azure/AzureApplicationInsightsServiceInterp.scala 0.00% 3 Missing ⚠️
...dsde/workbench/azure/AzureBatchServiceInterp.scala 0.00% 3 Missing ⚠️
.../workbench/azure/AzureContainerServiceInterp.scala 0.00% 3 Missing ⚠️
...titute/dsde/workbench/azure/AzureRelayInterp.scala 0.00% 3 Missing ⚠️
...te/dsde/workbench/azure/AzureVmServiceInterp.scala 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1713      +/-   ##
===========================================
- Coverage    24.66%   24.44%   -0.23%     
===========================================
  Files          104      105       +1     
  Lines         2724     2749      +25     
  Branches       247      253       +6     
===========================================
  Hits           672      672              
- Misses        2052     2077      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsaun jsaun merged commit b25c29d into develop Dec 17, 2024
1 check failed
@jsaun jsaun deleted the bennettn/azure-gov-update branch December 17, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants