Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDO-3037: Add support for filtering workflow dispatch runs by run-name. #7

Merged
merged 9 commits into from
Sep 7, 2023

Conversation

ichengchang
Copy link
Collaborator

@ichengchang ichengchang commented Aug 28, 2023

Ticket: DDO-3037

Description

This blog post describes what the current issue is with workflow_dispatch and a fix for the issue using GitHub run-name.

This ticket is for the upgrade of this GitHub Action to support run-name.

See this test run

@broadbot broadbot temporarily deployed to foo August 28, 2023 20:01 — with GitHub Actions Inactive
@broadbot broadbot temporarily deployed to foo August 28, 2023 20:08 — with GitHub Actions Inactive
@broadbot broadbot temporarily deployed to foo August 28, 2023 20:15 — with GitHub Actions Inactive
Copy link

@jyang-broad jyang-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane!
adds run-name filter to the python GHA.

README.md Outdated Show resolved Hide resolved
@jyang-broad
Copy link

Found it, can you update all instances of actions/checkout@v2 and actions/download-artifact@v2 to v3? I think the vs are still running v12 which is throwing the errors.

@broadbot broadbot temporarily deployed to foo August 29, 2023 18:34 — with GitHub Actions Inactive
@broadbot broadbot temporarily deployed to foo August 29, 2023 18:35 — with GitHub Actions Inactive
@broadbot broadbot temporarily deployed to foo August 29, 2023 19:01 — with GitHub Actions Inactive
@broadbot broadbot temporarily deployed to foo August 29, 2023 19:34 — with GitHub Actions Inactive
@broadbot broadbot temporarily deployed to foo August 29, 2023 19:41 — with GitHub Actions Inactive
@broadbot broadbot temporarily deployed to foo August 29, 2023 20:17 — with GitHub Actions Inactive
@broadbot broadbot temporarily deployed to foo September 6, 2023 21:46 — with GitHub Actions Inactive
@ichengchang ichengchang merged commit c909041 into master Sep 7, 2023
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants