test: no req

fx_test.go

@@ -3,6 +3,7 @@ package clearbank_test
 import (
 	"bytes"
 	"context"
+	"errors"
 	"io"
 	"net/http"
 	"testing"
@@ -26,3 +27,16 @@ func TestInitiateFxOrder(t *testing.T) {
 
 	assert.NoError(t, client.InitiateFxOrder(ctx, clearbank.FXPayload{}))
 }
+
+func TestInitiateFxOrder_FailedHttpRequest(t *testing.T) {
+	mockSigner := signature.NewMockSigner(t)
+	mockHttpClient := clearbank.NewMockHttpClient(t)
+	client := clearbank.NewClient("token", mockSigner, clearbank.WithHTTPClient(mockHttpClient))
+
+	ctx := clearbank.RequestIdContext(context.TODO(), "123")
+	mockSigner.On("Sign", ctx, mock.Anything).Return([]byte("signed"), nil).Once()
+
+	mockHttpClient.On("Do", mock.AnythingOfType("*http.Request")).Return(nil, errors.New("cannot do")).Once()
+
+	assert.Error(t, client.InitiateFxOrder(ctx, clearbank.FXPayload{}))
+}

rate_test.go

@@ -56,8 +56,7 @@ func TestFetchMarketrate_Fail(t *testing.T) {
 func TestFetchMarketrate_FailedHttpRequest(t *testing.T) {
 	mockHttpClient := clearbank.NewMockHttpClient(t)
 	client := clearbank.NewClient("token", nil, clearbank.WithHTTPClient(mockHttpClient))
-
-	mockHttpClient.On("Do", mock.AnythingOfType("*http.Request")).Return(&http.Response{}, errors.New("cannot do")).Once()
+	mockHttpClient.On("Do", mock.AnythingOfType("*http.Request")).Return(nil, errors.New("cannot do")).Once()
 
 	_, err := client.FetchMarketrate(context.TODO(), clearbank.MarketrateParams{FixedSide: clearbank.FixedSideBuy})
 	assert.Error(t, err)
@@ -91,8 +90,7 @@ func TestNegotiate_ValidationFailed(t *testing.T) {
 func TestNegotiate_FailedHttpRequest(t *testing.T) {
 	mockHttpClient := clearbank.NewMockHttpClient(t)
 	client := clearbank.NewClient("token", nil, clearbank.WithHTTPClient(mockHttpClient))
-
-	mockHttpClient.On("Do", mock.AnythingOfType("*http.Request")).Return(&http.Response{}, errors.New("cannot do")).Once()
+	mockHttpClient.On("Do", mock.AnythingOfType("*http.Request")).Return(nil, errors.New("cannot do")).Once()
 
 	_, err := client.Negotiate(context.TODO())
 	assert.Error(t, err)

test_test.go

@@ -53,8 +53,7 @@ func TestTest(t *testing.T) {
 func TestFailedHttpRequest(t *testing.T) {
 	mockHttpClient := clearbank.NewMockHttpClient(t)
 	client := clearbank.NewClient("token", local.NewNilSigner(), clearbank.WithHTTPClient(mockHttpClient))
-
-	mockHttpClient.On("Do", mock.AnythingOfType("*http.Request")).Return(&http.Response{}, errors.New("cannot do")).Once()
+	mockHttpClient.On("Do", mock.AnythingOfType("*http.Request")).Return(nil, errors.New("cannot do")).Once()
 
 	assert.Error(t, client.Test(context.TODO(), "hello!"))
 }