Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download of mp3 file failed #104

Closed
georf opened this issue Nov 23, 2017 · 3 comments
Closed

Download of mp3 file failed #104

georf opened this issue Nov 23, 2017 · 3 comments
Labels

Comments

@georf
Copy link

georf commented Nov 23, 2017

I get an error while downloading a mp3 file. But I don't know why its failing. If I download this file directly, I can fetch it. Perhaps you can add a detailed error message in the log file or only in verbose mode or something like that?

poca --config $(pwd) -v -l 
DAS ARD RADIOFEATURE. 1 ➕
 ⇵ ard-radiofeature-pulverfass-baltikum.12844s.mp3   [50 Mb]
 ⚠ Download of http://mp3-download.ard.de/radio/radiofeature/ard-radiofeature-pulverfass-baltikum.12844s.mp3  failed

Feed URL: http://www.ard.de/static/radio/radiofeature/rss/podcast.xml

wget http://mp3-download.ard.de/radio/radiofeature/ard-radiofeature-pulverfass-baltikum.12844s.mp3
--2017-11-23 11:26:32--  http://mp3-download.ard.de/radio/radiofeature/ard-radiofeature-pulverfass-baltikum.12844s.mp3
Resolving mp3-download.ard.de (mp3-download.ard.de)... 88.134.181.106, 88.134.181.97
Connecting to mp3-download.ard.de (mp3-download.ard.de)|88.134.181.106|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 53171689 (51M) [audio/mpeg]
Saving to: ‘ard-radiofeature-pulverfass-baltikum.12844s.mp3’

ard-radiofeature-pulverfass-baltikum.12844s.mp3       100%[===========================================================================================================================>]  50.71M  3.85MB/s   in 14s    

2017-11-23 11:26:46 (3.68 MB/s) - ‘ard-radiofeature-pulverfass-baltikum.12844s.mp3’ saved [53171689/53171689]
@brokkr
Copy link
Owner

brokkr commented Nov 23, 2017

The issue seems simple enough: the url in the feed is 'http://mp3-download.ard.de/radio/radiofeature/ard-radiofeature-pulverfass-baltikum.12844s.mp3 ' with a space at the end. I will have to test some more to figure out whether the problem is keeping the space or if something discards the space along the way.

As for more informative errors: It's a valid point and I could just pass on whatever error message is generated (in this case it would be "No connection adapters were found for 'http://mp3-download.ard.de/radio/radiofeature/ard-radiofeature-pulverfass-baltikum.12844s.mp3'") Just because I don't know what connection adapters are doesn't mean it might not make sense to somebody else :)

Mostly though I doubt it would be useful. I recently caught an error in BBC's Newhour feed where a single file in the middle of the feed was marked '403 UK only'. Like why? Usually it will just be human errors and there's little anyone can do about it except as you did, download it yourself if allowed.

@brokkr
Copy link
Owner

brokkr commented Nov 23, 2017

requests processes the url so that it becomes: http://mp3-download.ard.de/radio/radiofeature/ard-radiofeature-pulverfass-baltikum.12844s.mp3%20 I would awfully like to clean that up but there's a lot of ways for people to write urls wrong and no way to guard against them all. Some kind of general url sanitizing would require 3rd party libs and I think four is too many already.

I'll have a look at the output and see if there's a good way to add more informative errors somewhere.

@brokkr brokkr added this to the 1.1 milestone Nov 25, 2017
@brokkr brokkr removed this from the 1.1 milestone May 2, 2021
@brokkr brokkr added wontfix and removed enhancement labels May 2, 2021
@brokkr
Copy link
Owner

brokkr commented May 2, 2021

More informative errors is now #126
The wontfix applies to fixing server side naming errors

@brokkr brokkr closed this as completed May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants