Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop: Support for encodings other than UTF-8 #124

Open
brokkr opened this issue May 2, 2021 · 1 comment
Open

Drop: Support for encodings other than UTF-8 #124

brokkr opened this issue May 2, 2021 · 1 comment
Labels
Milestone

Comments

@brokkr
Copy link
Owner

brokkr commented May 2, 2021

No description provided.

@brokkr brokkr added this to the 2.0 milestone May 2, 2021
@brokkr brokkr added the drop label May 2, 2021
@brokkr
Copy link
Owner Author

brokkr commented May 18, 2021

Checking out support on various older platforms (older releases of Ubuntu, basically), I found one release, 18.04, that that could run poca (install and run requirements and with a version of Python that worked) AND that could bug out on discovering Unicode support (see #122). With a bit of jiggery pokery. But that still had a terminal that supported unicode.

So what's the point in insisting on a fallback option if we aren't supporting the platforms that would require it? And if we require unicode, does that mean only utf-8 encoding?

  • WSL apparently fakes a UTF-8 interface to underlying Windows NT UTF-16 innards, so that could work. (except in practice it doesn't seem like it has the capability of displaying it: see the issue on windows wsl)
  • Python on Windows itself uses UTF-8 for output since 3.6 but probably not for filenames?
  • MacOS? No idea.

Specifically:

  • Output: Output checks for encoding on stdout. Even if we drop the uni-UI, there's till the question of support for printing file names to the console.
  • Filenames: As long as rename is not used, there should not be any problem. But with rename on, it might be possible to crash. writing to a file takes a filename string. Python must then be responsible for whatever OS specific magic is required to turn that into a filename. So.... only if we use illegal characters?

@brokkr brokkr changed the title Deprecation: Support for encodings other than UTF-8 Drop: Support for encodings other than UTF-8 Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant