Correctly handle directory on rerun #523
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the mode detection consistent. Without this: Sometimes Emacs buffer used to use rustic mode and sometimes rust-ts-mode.
The source code is this:
fn main() {
let v = vec![1, 2, 3];
v[99];
}
While the code is incorrect, it does not have any compile error.
Fix possible babel test failures
Add docs for tree-sitter
Fix bugs related to tree sitter integration
Make rustic-cargo-clippy remember it's universal arguments
Fix flaky clippy test
Update docs
Improve minibuffer entry population for build and clippy
Fix flaky tests
CeleritasCelery
force-pushed
the
rerun-fix
branch
from
9f07d04
to
64cf248
Compare
Update rustic-cargo-test to remember it's universal argument
rustic-recompile will remember universal arguments passed
Firstly, use `add-to-list` rather than `setq` so that existing archives aren’t affected. In particular, Emacs includes NonGNU ELPA on the list and current instructions remove that archive. Secondly, prefer https over http when specifying URL of MELPA.
Update package-archives modification code in README
Currently rustic will override the default-directory to the workspace root after a compilation is finished. This enables it to correctly find the paths in error messages. But it also means that if you rerun a command it will rerun in the root crate instead of the original one. This change adds a new variable to track the original directory and resets it when we rerun.
CeleritasCelery
force-pushed
the
rerun-fix
branch
from
64cf248
to
051bab1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently rustic will override the
default-directoryto the workspace root after a compilation is finished. This enables it to correctly find the paths in error messages. But it also means that if you rerun a command it will rerun in the root crate instead of the original one.This change adds a new variable to track the original directory and resets it when we rerun.