update 38 to fix issue #1143

brunobuzzi · Aug 7, 2020 · 9aa6dd9 · 9aa6dd9
1 parent 5e09ae0
commit 9aa6dd9
Show file tree

Hide file tree

Showing 27 changed files with 37 additions and 55 deletions.
diff --git a/repository/BpmCore.package/BpmFrontOfficeRole.class/instance/getAverageTimeForTasks.st b/repository/BpmCore.package/BpmFrontOfficeRole.class/instance/getAverageTimeForTasks.st
@@ -4,7 +4,7 @@ getAverageTimeForTasks
 
 	distribution := OrderPreservingDictionary new.
 	totalTime := 0.
-	self tasks do: [:task | 
+	tasks do: [:task | 
 		distribution at: task name put: (task processDefinition getAverageTimeForTaskNamed: task name) asSeconds.
 	].
 

diff --git a/repository/BpmCore.package/BpmFrontOfficeRole.class/methodProperties.json b/repository/BpmCore.package/BpmFrontOfficeRole.class/methodProperties.json
@@ -10,7 +10,7 @@
 	"instance" : {
 		"asBackofficeRole" : "brunobb 03/25/2019 09:02",
 		"asFrontofficeRole" : "BrunoBB 12/18/2015 14:27",
-		"getAverageTimeForTasks" : "BrunoBB 11/08/2016 09:02",
+		"getAverageTimeForTasks" : "brunobb 08/07/2020 10:17",
 		"isFrontofficeRole" : "brunobb 12/27/2017 13:22",
 		"registerInApplication:" : "brunobb 02/04/2020 08:00",
 		"reportAverageTimeDistributionForAllTasks" : "BrunoBB 11/08/2016 09:04",

diff --git a/...ory/BpmCore.package/BpmProcessDefinition.class/instance/getFormDefinitionNamed.ifNone..st b/...ory/BpmCore.package/BpmProcessDefinition.class/instance/getFormDefinitionNamed.ifNone..st
diff --git a/repository/BpmCore.package/BpmProcessDefinition.class/instance/getTaskNames.st b/repository/BpmCore.package/BpmProcessDefinition.class/instance/getTaskNames.st
@@ -2,4 +2,4 @@ get artifacts
 getTaskNames
 	"The receiver answer a collection with all names of it's tasks <aBpmTaskDefinition>"
 
-	^self getTasks collect: [:each | each name]
+	^executionPath getTaskNames
diff --git a/repository/BpmCore.package/BpmProcessDefinition.class/instance/getTasks.st b/repository/BpmCore.package/BpmProcessDefinition.class/instance/getTasks.st
diff --git a/repository/BpmCore.package/BpmProcessDefinition.class/instance/tasksAndSubProcessTasksDo..st b/repository/BpmCore.package/BpmProcessDefinition.class/instance/tasksAndSubProcessTasksDo..st
@@ -0,0 +1,4 @@
+get artifacts
+tasksAndSubProcessTasksDo: aBlock
+
+	^executionPath tasksAndSubProcessTasksDo: aBlock
diff --git a/repository/BpmCore.package/BpmProcessDefinition.class/methodProperties.json b/repository/BpmCore.package/BpmProcessDefinition.class/methodProperties.json
@@ -122,7 +122,6 @@
 		"getFieldsNamed:in:initialValue:endValue:" : "brunobb 11/26/2018 12:06",
 		"getFieldsNamed:in:withValue:" : "brunobb 11/26/2018 12:00",
 		"getFinishedProcessMatrix" : "brunobb 02/06/2020 10:34",
-		"getFormDefinitionNamed:ifNone:" : "BrunoBB 02/23/2016 14:13",
 		"getFormsNamesWithFieldNamed:" : "brunobb 11/26/2018 08:05",
 		"getGatewayNamed:ifNone:" : "BrunoBB 11/28/2015 19:50",
 		"getHeatMapColorsAndNumersForArtifacts" : "brunobb 07/30/2020 12:35",
@@ -164,8 +163,7 @@
 		"getTakenProcessMatrix" : "brunobb 02/06/2020 10:34",
 		"getTaskCountFor:" : "brunobb 01/31/2018 12:05",
 		"getTaskNamed:ifNone:" : "BrunoBB 11/28/2015 19:53",
-		"getTaskNames" : "BrunoBB 02/18/2016 12:15",
-		"getTasks" : "BrunoBB 12/10/2015 06:36",
+		"getTaskNames" : "brunobb 08/07/2020 10:33",
 		"getTimerBlockSource" : "brunobb 08/06/2020 13:19",
 		"getTopProcess" : "BrunoBB 06/28/2016 12:20",
 		"getTopSubProcessTaskDefinition" : "brunobb 07/31/2020 11:16",
@@ -268,6 +266,7 @@
 		"summaryTitle" : "brunobb 02/09/2018 11:09",
 		"switchAvailableValue" : "brunobb 12/04/2018 07:32",
 		"switchImmutableValue" : "brunobb 03/28/2018 09:47",
+		"tasksAndSubProcessTasksDo:" : "brunobb 08/07/2020 10:38",
 		"throwNoCreationPermissionExceptionFor:" : "BrunoBB 11/22/2015 15:54",
 		"toggleAnonymousStart" : "brunobb 08/14/2019 09:47",
 		"updateFieldsOf:" : "BrunoBB 02/12/2016 06:20",

diff --git a/repository/BpmCore.package/BpmProcessPathDefinition.class/instance/getTaskNames.st b/repository/BpmCore.package/BpmProcessPathDefinition.class/instance/getTaskNames.st
@@ -0,0 +1,5 @@
+other
+getTaskNames
+	"The receiver answer a collection with all names of it's tasks <aBpmTaskDefinition>"
+
+	^tasks collect: [:each | each name]
diff --git a/repository/BpmCore.package/BpmProcessPathDefinition.class/instance/hasTaskNamed..st b/repository/BpmCore.package/BpmProcessPathDefinition.class/instance/hasTaskNamed..st
@@ -1,4 +1,4 @@
 other
 hasTaskNamed: aString
 
-	^self tasks anySatisfy: [:each | each name = aString]
+	^tasks anySatisfy: [:each | each name = aString]
diff --git a/repository/BpmCore.package/BpmProcessPathDefinition.class/instance/tasks..st b/repository/BpmCore.package/BpmProcessPathDefinition.class/instance/tasks..st
diff --git a/repository/BpmCore.package/BpmProcessPathDefinition.class/instance/tasks.st b/repository/BpmCore.package/BpmProcessPathDefinition.class/instance/tasks.st
diff --git a/...ory/BpmCore.package/BpmProcessPathDefinition.class/instance/tasksAndSubProcessTasksDo..st b/...ory/BpmCore.package/BpmProcessPathDefinition.class/instance/tasksAndSubProcessTasksDo..st
@@ -0,0 +1,5 @@
+Accessing
+tasksAndSubProcessTasksDo: aBlock
+
+	tasks do: aBlock.
+	subProcessTasks do: aBlock.
diff --git a/repository/BpmCore.package/BpmProcessPathDefinition.class/methodProperties.json b/repository/BpmCore.package/BpmProcessPathDefinition.class/methodProperties.json
@@ -37,14 +37,15 @@
 		"getStartTimerBlock" : "brunobb 08/06/2020 13:01",
 		"getSubProcessTaskNamed:ifNone:" : "BrunoBB 10/28/2015 12:13",
 		"getTaskNamed:ifNone:" : "BrunoBB 10/28/2015 12:12",
+		"getTaskNames" : "brunobb 08/07/2020 10:34",
 		"getTimerBlockSource" : "brunobb 08/06/2020 13:19",
 		"getTransitionNamed:ifNone:" : "BrunoBB 10/30/2015 05:44",
 		"hasCreationTimer" : "brunobb 08/06/2020 13:10",
 		"hasGatewayConditionIncludingFieldNamed:" : "BrunoBB 04/19/2016 16:19",
 		"hasOrbeonFormNamed:" : "BrunoBB 01/23/2016 07:26",
 		"hasOrbeonOrSeasideTasks" : "brunobb 04/24/2018 08:59",
 		"hasScriptNamed:" : "BrunoBB 06/22/2016 11:43",
-		"hasTaskNamed:" : "BrunoBB 12/21/2015 09:48",
+		"hasTaskNamed:" : "brunobb 08/07/2020 10:19",
 		"initialize" : "BrunoBB 06/22/2016 11:40",
 		"intermediateEvents" : "BrunoBB 10/27/2015 17:25",
 		"intermediateEvents:" : "BrunoBB 10/27/2015 17:25",
@@ -61,5 +62,4 @@
 		"startEventOutTransitionsLast" : "brunobb 08/06/2020 11:48",
 		"subProcessTasks" : "BrunoBB 10/27/2015 15:21",
 		"subProcessTasks:" : "BrunoBB 10/27/2015 15:21",
-		"tasks" : "BrunoBB 10/27/2015 15:21",
-		"tasks:" : "BrunoBB 10/27/2015 15:21" } }
+		"tasksAndSubProcessTasksDo:" : "brunobb 08/07/2020 10:38" } }
diff --git a/repository/BpmCore.package/BpmRole.class/instance/tasks..st b/repository/BpmCore.package/BpmRole.class/instance/tasks..st
diff --git a/repository/BpmCore.package/BpmRole.class/instance/tasks.st b/repository/BpmCore.package/BpmRole.class/instance/tasks.st
diff --git a/repository/BpmCore.package/BpmRole.class/instance/tasksDo..st b/repository/BpmCore.package/BpmRole.class/instance/tasksDo..st
@@ -0,0 +1,4 @@
+Accessing
+tasksDo: aBlock
+
+	tasks do: aBlock
diff --git a/repository/BpmCore.package/BpmRole.class/instance/userGroups..st b/repository/BpmCore.package/BpmRole.class/instance/userGroups..st
diff --git a/repository/BpmCore.package/BpmRole.class/instance/userGroups.st b/repository/BpmCore.package/BpmRole.class/instance/userGroups.st
diff --git a/repository/BpmCore.package/BpmRole.class/methodProperties.json b/repository/BpmCore.package/BpmRole.class/methodProperties.json
@@ -44,13 +44,10 @@
 		"removeGroup:" : "brunobb 01/27/2020 11:15",
 		"removeResponsibility:" : "brunobb 01/27/2020 11:07",
 		"reportNumberOfUsersInTimeDistributionFrom:to:" : "brunobb 01/27/2020 11:07",
-		"tasks" : "brunobb 01/27/2020 11:07",
-		"tasks:" : "brunobb 01/27/2020 11:07",
+		"tasksDo:" : "brunobb 08/07/2020 10:22",
 		"ungrantUser:" : "brunobb 01/27/2020 11:07",
 		"ungrantUser:ifAbsent:" : "brunobb 01/30/2020 07:06",
 		"unregisterFromApplication:ifAbsent:" : "brunobb 02/04/2020 08:48",
-		"userGroups" : "brunobb 01/27/2020 11:09",
-		"userGroups:" : "brunobb 01/27/2020 11:09",
 		"users" : "brunobb 01/27/2020 11:07",
 		"users:" : "brunobb 01/27/2020 11:07",
 		"usersAssociationsSize" : "bruno 07/24/2020 13:21",

diff --git a/repository/BpmCore.package/monticello.meta/version b/repository/BpmCore.package/monticello.meta/version
diff --git a/repository/BpmRuntime.package/BpmUser.class/instance/getGrantedArtifacts.st b/repository/BpmRuntime.package/BpmUser.class/instance/getGrantedArtifacts.st
@@ -5,6 +5,6 @@ getGrantedArtifacts
 
 	artifacts := Set new.
 
-	roles do: [:each | artifacts addAll: each tasks].
+	roles do: [:eachRole | eachRole tasksDo: [:task | artifacts add: task]].
 
 	^artifacts asOrderedCollection
diff --git a/repository/BpmRuntime.package/BpmUser.class/instance/getGrantedArtifactsIn..st b/repository/BpmRuntime.package/BpmUser.class/instance/getGrantedArtifactsIn..st
@@ -5,6 +5,6 @@ getGrantedArtifactsIn: aBpmEnviroment
 
 	artifacts := Set new.
 
-	(self rolesIn: aBpmEnviroment) do: [:each | artifacts addAll: each tasks].
+	(self rolesIn: aBpmEnviroment) do: [:eachRole | eachRole tasksDo: [:task | artifacts add: task]].
 
 	^artifacts asOrderedCollection
diff --git a/repository/BpmRuntime.package/BpmUser.class/methodProperties.json b/repository/BpmRuntime.package/BpmUser.class/methodProperties.json
@@ -75,8 +75,8 @@
 		"getFinishedTaskQuantityDistributionIn:from:to:satisfying:" : "brunobb 01/27/2020 11:09",
 		"getGatewayDoneBorderColor" : "brunobb 01/27/2020 11:09",
 		"getGatewayDoneFillColor" : "brunobb 01/27/2020 11:09",
-		"getGrantedArtifacts" : "brunobb 01/27/2020 11:09",
-		"getGrantedArtifactsIn:" : "brunobb 01/27/2020 11:09",
+		"getGrantedArtifacts" : "brunobb 08/07/2020 10:46",
+		"getGrantedArtifactsIn:" : "brunobb 08/07/2020 10:45",
 		"getGrantedTasks" : "brunobb 01/27/2020 11:09",
 		"getGrantedTasksIn:" : "brunobb 01/27/2020 11:09",
 		"getInboxFor:" : "brunobb 01/27/2020 11:09",

diff --git a/repository/BpmRuntime.package/monticello.meta/version b/repository/BpmRuntime.package/monticello.meta/version
diff --git a/...tory/BpmXpdl.package/BpmProcessGenerator.class/instance/attachEventsToTaskIn.withXPDL..st b/...tory/BpmXpdl.package/BpmProcessGenerator.class/instance/attachEventsToTaskIn.withXPDL..st
@@ -2,7 +2,7 @@ process definition creation
 attachEventsToTaskIn: aBpmProcessDefinition withXPDL: aXPDLWorflowProcess
 	"The receiver attach events to tasks in <aBpmProcessDefinition> as is defined in xpdl process <aXPDLWorflowProcess>"
 
-	(aBpmProcessDefinition getTasks asArray, aBpmProcessDefinition getSubProcessTasks asArray) do: [:taskDefinition | | xpdlElement |
+	aBpmProcessDefinition tasksAndSubProcessTasksDo: [:taskDefinition | | xpdlElement |
 		xpdlElement := aXPDLWorflowProcess getTaskNamed: taskDefinition name ifNone: [aXPDLWorflowProcess getSubprocessNamed: taskDefinition name ifNone: [^XpdlIncompleteContentsException signal: 'Activity named [', taskDefinition name,'] not found']].
 		xpdlElement attachedEvents do: [:eventNode | | bpmEvent |
 			bpmEvent := aBpmProcessDefinition getIntermediateEventNamed: eventNode getName ifNone: [].

diff --git a/repository/BpmXpdl.package/BpmProcessGenerator.class/methodProperties.json b/repository/BpmXpdl.package/BpmProcessGenerator.class/methodProperties.json
@@ -2,7 +2,7 @@
 	"class" : {
 		"on:" : "BrunoBB 10/31/2015 15:57" },
 	"instance" : {
-		"attachEventsToTaskIn:withXPDL:" : "brunobb 08/05/2019 11:11",
+		"attachEventsToTaskIn:withXPDL:" : "brunobb 08/07/2020 10:40",
 		"connectSubProcessTaskWithSubProcess" : "BrunoBB 06/29/2016 09:35",
 		"createEmbeddedSubProcessFor:basedOn:package:" : "brunobb 08/06/2020 10:08",
 		"createParticipantDefinitionsOf:" : "bruno 07/27/2020 14:57",