Skip to content

Commit

Permalink
Remove magicHtml option #379128 (#15)
Browse files Browse the repository at this point in the history
With #14 , we've also bumped a couple of dependencies. One of it,
`webpack-dev-server` now causes issues while serving a template via `npx
webpack serve --config webpack.config.js --mode development --progress`.
The reason for the failure is the switch to Webpack v5 which introduced
a breaking change* regarding the `magicHtml` option, which has been
removed completly. As we've never used that feature, we can safely
remove the option now.

We should afterwards check in detail whether this solves all issues or
if there are more breaking changes.


*https://github.com/webpack/webpack-dev-server/blob/master/migration-v5.md
  • Loading branch information
innerjoin authored Mar 28, 2024
1 parent 19ff20b commit 2ffc3f2
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 7 deletions.
1 change: 0 additions & 1 deletion dist/main.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/main.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/types.d.ts.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@bsi-cx/design-build",
"version": "1.13.4",
"version": "1.13.5",
"description": "A webpack config builder to create a design for BSI CX.",
"private": false,
"engines": {
Expand Down
1 change: 0 additions & 1 deletion src/webpack-config-builder.js
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,6 @@ export default class WebpackConfigBuilder {
_getDevServerConfig() {
return {
port: this.config.devServerPort,
magicHtml: false,
hot: false,
liveReload: false,
static: {
Expand Down

0 comments on commit 2ffc3f2

Please sign in to comment.