-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop blog #5
Develop blog #5
Conversation
✔️ Deploy Preview for btcpayserver-blog-preview ready! 🔨 Explore the source changes: b5824d8 🔍 Inspect the deploy log: https://app.netlify.com/sites/btcpayserver-blog-preview/deploys/60e891814a83170007760070 😎 Browse the preview: https://deploy-preview-5--btcpayserver-blog-preview.netlify.app |
Awesome, this is definitely going in the right direction -- good job! |
Regarding the linkcheck.
Other than that, there are a few links that are probably broken in your code:
|
Yes, as Zax pointed out, the ones that aren't really broken should be excluded from the check, see the exclude list in package.json for reference. |
More link fixes
16242c4
to
5748336
Compare
Now the linkcheck works again :) |
This is so cool and looks great already! Very good job, @activefog Remaining TODOs I noticed:
Again, really cool -- looking forward to launching this! Once the site is live we can apply for Algolia DocSearch, which might improve the search. Not sure if needed though. /cc @pavlenex |
Thanks all -- I didn't realize there was a link-check exclusions list Agreed @d11n -- latest commit updates the styles you mentioned. Good catch on the search flyout -- I hadn't actually tried searching yet. Another bug I'm noticing is that if you go into page 2, etc., of the posts index, you see "Page 2 | | BTCPay ..." (i.e., two pipes instead of one) as the page title in the browser tab. I was able to fix this locally by deleting the pipe on line 56 of the handleOptions.js file in the vuepress-plugin-blog module, but short of forking that module and adding the fork to package.json, I'm not sure how to get this to work in the build process. Any ideas on how to monkey patch this? Or perhaps something else in the code that I'm missing? |
@activefog I fixed that "Page 2 | | BTCPay" issue in b797f0f. Nevertheless there is one more place the fix does not work: The index page of a category, which does not get the title via the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really awesome already. Reviewed it and it is good to go imho. We can improve minor stuff later, but I think this is ready for prime time now.
Very solid work, @activefog -- thanks for all the effort!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let us know when you guys are ready to do a DNS migration.
Awesome work the blog looks really dope 🔥
@activefog If you think this is ready I'll merge. Preview will then be here: https://btcpayserver.github.io/blog/ Once this is merged we can do the DNS switch and point the A record to the four GH Pages IPs as for the website and directory. |
Can we have the sponsors show on every page? |
I second this. |
Thanks all -- I added sponsors to all pages. In general, I think this all looks good, and I agree that it is ready to go. One additional minor thing I see is that category page titles are not getting capitalized (in browser tabs). Frustratingly, I don't see a way to config that through vuepress-plugin-blog, which is creating the pages automatically (https://vuepress-plugin-blog.ulivz.com/config/ only shows a way to update the directory title, not the individual category pages, which I would expect to see as an "itemTitle" option). I'm still learning Vue, and perhaps there is another trick to get this done that I am missing? Either way, I don't think this needs to hold back the cut-over from the WordPress site which currently has worse bugs anyway :) |
Agreed, this annoying issue doesn't have to hold out the release of the new blog in it's current state. Very nicely done, and quickly, thanks for that! <3 |
@activefog yes, that's what I meant above, I guess we need to send in a fix as PR in the blog plugin. Let's get this out there first! Merging … |
No description provided.