Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop blog #5

Merged
merged 53 commits into from
Jul 9, 2021
Merged

Develop blog #5

merged 53 commits into from
Jul 9, 2021

Conversation

sjc5
Copy link
Contributor

@sjc5 sjc5 commented Jul 1, 2021

No description provided.

@netlify
Copy link

netlify bot commented Jul 1, 2021

✔️ Deploy Preview for btcpayserver-blog-preview ready!

🔨 Explore the source changes: b5824d8

🔍 Inspect the deploy log: https://app.netlify.com/sites/btcpayserver-blog-preview/deploys/60e891814a83170007760070

😎 Browse the preview: https://deploy-preview-5--btcpayserver-blog-preview.netlify.app

@dennisreimann
Copy link
Member

Awesome, this is definitely going in the right direction -- good job!

@Zaxounette
Copy link
Contributor

Regarding the linkcheck.

  • All the HTTP_429 can be ignored I think and added as exceptions, they work when I access them, they just get blocked by automation.
  • All the kraken HTTP_503 will probably be added as exceptions by Dennis, like on the docs repo.
  • Some of the 404 work, some are broken (the broken ones are 1 year+ old)

Other than that, there are a few links that are probably broken in your code:

├─BROKEN─ http://araspitzu/ (BLC_UNKNOWN)
├─BROKEN─ http://bolatovumar/ (HTTP_undefined)

@dennisreimann
Copy link
Member

Yes, as Zax pointed out, the ones that aren't really broken should be excluded from the check, see the exclude list in package.json for reference.

More link fixes
@dennisreimann
Copy link
Member

Now the linkcheck works again :)

@dennisreimann
Copy link
Member

dennisreimann commented Jul 8, 2021

This is so cool and looks great already! Very good job, @activefog

Remaining TODOs I noticed:

  • Search flyout in dark mode needs color fixes (similar to the pagination)
  • The "Last Updated:" color at the end of an article doesn't fit
  • The links in the subline "Posted in CATEGORY by AUTHOR on DATE" could use a more subtle color.

Again, really cool -- looking forward to launching this!

Once the site is live we can apply for Algolia DocSearch, which might improve the search. Not sure if needed though. /cc @pavlenex

@sjc5
Copy link
Contributor Author

sjc5 commented Jul 9, 2021

Thanks all -- I didn't realize there was a link-check exclusions list

Agreed @d11n -- latest commit updates the styles you mentioned. Good catch on the search flyout -- I hadn't actually tried searching yet.

Another bug I'm noticing is that if you go into page 2, etc., of the posts index, you see "Page 2 | | BTCPay ..." (i.e., two pipes instead of one) as the page title in the browser tab. I was able to fix this locally by deleting the pipe on line 56 of the handleOptions.js file in the vuepress-plugin-blog module, but short of forking that module and adding the fork to package.json, I'm not sure how to get this to work in the build process. Any ideas on how to monkey patch this? Or perhaps something else in the code that I'm missing?

@dennisreimann
Copy link
Member

@activefog I fixed that "Page 2 | | BTCPay" issue in b797f0f.

Nevertheless there is one more place the fix does not work: The index page of a category, which does not get the title via the getPaginationPageTitle function. I'd suggest we create a PR to solve this -- there is a similar request already vuepress/vuepress-plugin-blog#90

Copy link
Member

@dennisreimann dennisreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really awesome already. Reviewed it and it is good to go imho. We can improve minor stuff later, but I think this is ready for prime time now.

Very solid work, @activefog -- thanks for all the effort!

Copy link
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let us know when you guys are ready to do a DNS migration.

Awesome work the blog looks really dope 🔥

@dennisreimann
Copy link
Member

@activefog If you think this is ready I'll merge. Preview will then be here: https://btcpayserver.github.io/blog/

Once this is merged we can do the DNS switch and point the A record to the four GH Pages IPs as for the website and directory.

@Kukks
Copy link
Member

Kukks commented Jul 9, 2021

Can we have the sponsors show on every page?

@Zaxounette
Copy link
Contributor

Can we have the sponsors show on every page?

I second this.
Currently they are missing in the main page and the different category pages.

@sjc5
Copy link
Contributor Author

sjc5 commented Jul 9, 2021

Thanks all -- I added sponsors to all pages.

In general, I think this all looks good, and I agree that it is ready to go.

One additional minor thing I see is that category page titles are not getting capitalized (in browser tabs). Frustratingly, I don't see a way to config that through vuepress-plugin-blog, which is creating the pages automatically (https://vuepress-plugin-blog.ulivz.com/config/ only shows a way to update the directory title, not the individual category pages, which I would expect to see as an "itemTitle" option). I'm still learning Vue, and perhaps there is another trick to get this done that I am missing? Either way, I don't think this needs to hold back the cut-over from the WordPress site which currently has worse bugs anyway :)

@Zaxounette
Copy link
Contributor

Agreed, this annoying issue doesn't have to hold out the release of the new blog in it's current state.

Very nicely done, and quickly, thanks for that! <3

@dennisreimann
Copy link
Member

@activefog yes, that's what I meant above, I guess we need to send in a fix as PR in the blog plugin.

Let's get this out there first! Merging …

@dennisreimann dennisreimann merged commit 2a10322 into master Jul 9, 2021
@dennisreimann dennisreimann deleted the develop-blog branch July 9, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants