Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Grandnode and nopcommerce to docs #1374

Merged
merged 2 commits into from
Mar 2, 2024

Conversation

arshbot
Copy link
Contributor

@arshbot arshbot commented Feb 28, 2024

Tackles #1372

Dependent on the following PRs:

@arshbot arshbot changed the title Grandnode and nopcommerce Add Grandnode and nopcommerce to docs Feb 28, 2024
@pavlenex
Copy link
Contributor

pavlenex commented Feb 29, 2024

For some reason banner is still broken in preview despite

@pavlenex
Copy link
Contributor

@dennisreimann what is required in order to properly render an image from external repo to /docs?

@arshbot
Copy link
Contributor Author

arshbot commented Feb 29, 2024

Dumb question, but when you tested did you rerun ./setup-deps.sh?

Just went through and can verify the url in your commits (https://github.com/btcpayserver/nopcommerce/blob/f24ed2182ae192f8cc81e70c6161020a05984257/nopCommerceAcceptBitcoin.png) doesn't work because they link to the github page containing the image, not the image itself.

tested again with params raw=true in the url (https://github.com/btcpayserver/nopcommerce/blob/main/nopCommerceAcceptBitcoin.png?raw=true) and it worked again locally.

If it still isn't working, could you check $PROJECT_PATH/docs/Nopcommerce/README.md and paste line 7? If it's the right url it really should work unless I'm missing something

@arshbot
Copy link
Contributor Author

arshbot commented Feb 29, 2024

the grandnode url you added really should have worked...

@pavlenex
Copy link
Contributor

pavlenex commented Mar 2, 2024

hey @arshbot I am lost, I'll merge this one and see if it's caching related. It seems raw github should work no idea why netlify preview doesn't show it.

@pavlenex pavlenex merged commit c599659 into btcpayserver:master Mar 2, 2024
5 checks passed
@pavlenex
Copy link
Contributor

pavlenex commented Mar 2, 2024

Can confirm it works now, I assume caching with Netlify previews was the problem, thanks for contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants