-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MERGE AFTER 2.0] Remove docs on customizing checkout page #1385
[MERGE AFTER 2.0] Remove docs on customizing checkout page #1385
Conversation
Why not removing the article itself and the images as well? Also note: To be merged when 2.0 is out. |
I wasn't sure so sure, that's why I didn't remove it. I would do that. Yea, I'm aware that it's after 2.0 merge. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we should completely remove the page, but most of it. We should keep the "Developing and extending a custom theme" part and adapt it to what we've added with the branding options.
Can you re-add that page with the "Developing and extending a custom theme" only (until "2. Bootstrap themes") and I can adjust it from there? Thanks!
Sure @dennisreimann |
Updated @dennisreimann |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adapted it to fit with the current state.
To be merged when 2.0 is out. |
@dennisreimann mentioned
I agree with this, @NicolasDorier ? |
Seems good to me |
Based on the BTCPay Server 2.0: Megathread , part of the task is to Remove docs on https://docs.btcpayserver.org/Development/Theme/#checkout-page-themes
This PR tends to resolve it, by removing the path from the side bar so that it is not accessible