Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure API examples, add more #1387

Merged
merged 6 commits into from
Apr 26, 2024
Merged

Conversation

ndeet
Copy link
Contributor

@ndeet ndeet commented Apr 23, 2024

The idea is outlined in issue #1371 where we structure examples for eCommerce use case and also on managing BTCPay Server by creating users and stores. All the examples for PHP, Node.js and cURL have the same structure while differing in details according to language, e.g. you can't really do a webhook validation endpoint with cURL.

  • cURL
  • PHP
  • NodeJS
  • overview
  • testing

Fixes #1371

@ndeet ndeet marked this pull request as ready for review April 25, 2024 09:23
@ndeet
Copy link
Contributor Author

ndeet commented Apr 25, 2024

@pavlenex this is now ready

@pavlenex pavlenex requested review from dennisreimann and Kukks April 26, 2024 09:38
@pavlenex
Copy link
Contributor

Great, a dev would need to review these to get merged though.

@pavlenex pavlenex linked an issue Apr 26, 2024 that may be closed by this pull request
Copy link
Member

@dennisreimann dennisreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. If I understand btcpayserver#5822 correctly, we refrain from adding the examples inline with the API docs and I think this is fine with these updates.

@pavlenex pavlenex merged commit 772a45d into btcpayserver:master Apr 26, 2024
5 checks passed
@ndeet ndeet deleted the api-examples branch May 5, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Greenfield API example with cURL API examples streamlining
3 participants