-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conference PoS and Bolt Card guide. #1409
Conversation
Few typos and grammar fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added my changes directly to the branch, LGTM now
Thanks a lot 🫂 Any idea/suggestion where we put the guide in the menu structure? |
@pavlenex please check menu entry and if you can see any incosistencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work both of you, added some nits suggestions.
Co-authored-by: Pavlenex <pavle@pavle.org>
@pavlenex thank you! Merged your suggestions. You can merge PR now if nothing else to fix. |
The final thing here is do we want to include the video from your presentation in Prague? @webwworthy had that video so honestly I would add embed here. And if we want to have shorter/more concise video, we can always do that later, but having video in the guide is imo quite beneficial. |
@pavlenex Added as discussed, also added toc table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvements, this one is now ready to be merged next week (Tuesday-Thursday), when we're aiming to announce the guide. @webwworthy will come up with 30sec preview video for Twitter.
To access this page in preview you need to manually enter the path
/Conference-PoS-guide/
as there is no menu item assigned yet (as it is unclear where to put it, see below).to be discussed:
todo:
cc @rockstardev @pavlenex