Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conference PoS and Bolt Card guide. #1409

Merged
merged 6 commits into from
Jul 10, 2024

Conversation

ndeet
Copy link
Contributor

@ndeet ndeet commented Jun 9, 2024

To access this page in preview you need to manually enter the path /Conference-PoS-guide/ as there is no menu item assigned yet (as it is unclear where to put it, see below).

to be discussed:

  • where should we place this guide? A new "Guides" or "How to" section in the User guide? Somewhere else?
  • I left some // todo: where we need to clarify double check
  • instead of repeating everything in the guide we should link to existing guides like we do with the Blink plugin setup; we could also link to the Boldcard plugin readme of Nicolas but it seems this part may be clearer this way if we repeat it with the store names and examples

todo:

  • will add some images where relevant, adding it for each tiny step seems to be a bit too much and the article would get too long, imo (thoughts?)

cc @rockstardev @pavlenex

Copy link
Member

@rockstardev rockstardev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added my changes directly to the branch, LGTM now

@ndeet
Copy link
Contributor Author

ndeet commented Jun 11, 2024

 Thanks a lot 🫂 Any idea/suggestion where we put the guide in the menu structure?

@ndeet ndeet marked this pull request as ready for review June 20, 2024 10:39
@ndeet
Copy link
Contributor Author

ndeet commented Jun 20, 2024

@pavlenex please check menu entry and if you can see any incosistencies

Copy link
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work both of you, added some nits suggestions.

docs/Conference-PoS-guide.md Outdated Show resolved Hide resolved
docs/Conference-PoS-guide.md Outdated Show resolved Hide resolved
docs/Conference-PoS-guide.md Outdated Show resolved Hide resolved
docs/Conference-PoS-guide.md Outdated Show resolved Hide resolved
docs/Conference-PoS-guide.md Outdated Show resolved Hide resolved
Co-authored-by: Pavlenex <pavle@pavle.org>
@ndeet
Copy link
Contributor Author

ndeet commented Jun 27, 2024

@pavlenex thank you! Merged your suggestions. You can merge PR now if nothing else to fix.

@pavlenex
Copy link
Contributor

The final thing here is do we want to include the video from your presentation in Prague? @webwworthy had that video so honestly I would add embed here. And if we want to have shorter/more concise video, we can always do that later, but having video in the guide is imo quite beneficial.

@ndeet
Copy link
Contributor Author

ndeet commented Jul 2, 2024

@pavlenex Added as discussed, also added toc table.

Copy link
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements, this one is now ready to be merged next week (Tuesday-Thursday), when we're aiming to announce the guide. @webwworthy will come up with 30sec preview video for Twitter.

@pavlenex pavlenex merged commit e34dd6f into btcpayserver:master Jul 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants