Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open cart doc improvement #1422

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Conversation

TChukwuleta
Copy link
Contributor

Part implementation of #1352 for Open cart.

@pavlenex
Copy link
Contributor

pavlenex commented Oct 2, 2024

I wont' be prioritizng a review on this one for a few weeks, quick glance it's really overwhelmingly screams chatgpt. If you could actually proofread it yourself and rephrase I could then prioritize it.

Copy link
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TChukwuleta As said above, if you're using chatgpt, please proofread to ensure accuracy before pushing a PR, it takes more time to edit out this PR from repetative unecessary marketing buzzwords than it takes to generate it.

Most of the changes are okay, but please re-write the feature and benefits section according to my comments.

docs/OpenCart.md Outdated Show resolved Hide resolved
docs/OpenCart.md Outdated Show resolved Hide resolved
docs/OpenCart.md Outdated Show resolved Hide resolved
docs/OpenCart.md Outdated Show resolved Hide resolved
docs/OpenCart.md Outdated Show resolved Hide resolved
docs/OpenCart.md Outdated Show resolved Hide resolved
@TChukwuleta
Copy link
Contributor Author

Reviewed them... Apologies for the stress...

Can you take another look @pavlenex

@pavlenex pavlenex merged commit 8ef500a into btcpayserver:master Nov 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants