Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big commerce documentation #1431

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Conversation

TChukwuleta
Copy link
Contributor

Include Big commerce docs

cc. @pavlenex

@pavlenex
Copy link
Contributor

pavlenex commented Sep 26, 2024

I don't see it in the sidebar?

Screenshot 2024-09-26 at 11 35 53

Edit: I was you've added it to plugins, let's keep this under e-commerce integration, I know it's technically more correct, but imo makes sense to bundle them all in one spot vs distribute e-commerce integration everywhere.

@TChukwuleta
Copy link
Contributor Author

TChukwuleta commented Sep 26, 2024

I put it under plugins

Plus I picked the documentation from the Plugin Readme

@TChukwuleta
Copy link
Contributor Author

Updated @pavlenex

@pavlenex
Copy link
Contributor

pavlenex commented Sep 26, 2024

Does it only work with 2.0.0? @TChukwuleta ? If so we should probably say that in prerequisites.
You mention v1.4.8 or later how did we come up with that?

@TChukwuleta
Copy link
Contributor Author

It works with previous version (1.3 )and also 2.0... It was implemented before 2.0 , however it is compatible with 2.0

But yea, I'd include that in the docs

@pavlenex
Copy link
Contributor

pavlenex commented Oct 1, 2024

Alright, happy to merge once you're ready.

@pavlenex
Copy link
Contributor

pavlenex commented Oct 1, 2024

@TChukwuleta closing this one since it's already done on #1415

@pavlenex pavlenex closed this Oct 1, 2024
@TChukwuleta
Copy link
Contributor Author

Hey @pavlenex the reference PR #1415 is for Odoo.. while this is for BigCommerce

@pavlenex pavlenex reopened this Oct 2, 2024
@pavlenex
Copy link
Contributor

pavlenex commented Oct 2, 2024

My bad @TChukwuleta! Re-opened.

@pavlenex
Copy link
Contributor

pavlenex commented Oct 3, 2024

@TChukwuleta If we add 2.0.0 as requirement, I believe we can merge this one.

@TChukwuleta
Copy link
Contributor Author

TChukwuleta commented Oct 3, 2024

Yea... We can

Would add it shortly

@TChukwuleta
Copy link
Contributor Author

Hey @pavlenex .. Updated the ReadMe with the required version.

image

@pavlenex pavlenex merged commit 942fdf8 into btcpayserver:master Oct 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants