main: add flag to write execution traces #2223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Execution traces are part of the go runtime tooling and is useful to check what is slowing down the ibd. For example, a slow ibd because of slow block downloads from peers won't show up on cpu profiling but will on a trace.
Pull Request Test Coverage Report for Build 10261087623Details
💛 - Coveralls |
guggero
approved these changes
Nov 5, 2024
| @@ -114,6 +114,7 @@ type config struct { | |||
| ConnectPeers []string `long:"connect" description:"Connect only to the specified peers at startup"` | |||
| CPUProfile string `long:"cpuprofile" description:"Write CPU profile to the specified file"` | |||
| MemoryProfile string `long:"memprofile" description:"Write memory profile to the specified file"` | |||
| TraceProfile string `long:"trace" description:"Write execution trace to the specified file"` | |||
There was a problem hiding this comment.
nit: call the flag traceprofile to not confuse it with a log level and be more in line with the other profile flags?
There was a problem hiding this comment.
Bump on this, can get merged once addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execution traces are part of the go runtime tooling and is useful to check what is slowing down the ibd. For example, a slow ibd because of slow block downloads from peers won't show up on cpu profiling but will on a trace.
Also execution tracing has gotten a lot better with go 1.22