Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btcutil: Add library functions for BIP-0352 silent payment _send_ support #2244

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

guggero
Copy link
Collaborator

@guggero guggero commented Sep 1, 2024

Still work in progress, test vectors aren't passing yet.

Goal is to address send support first as that's rather straightforward. Receive support is much more involved as it requires scanning the chain in a specific manner.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11427608455

Details

  • 238 of 324 (73.46%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 57.342%

Changes Missing Coverage Covered Lines Changed/Added Lines %
btcutil/silentpayments/address.go 98 138 71.01%
btcutil/silentpayments/input.go 140 186 75.27%
Totals Coverage Status
Change from base Build 11292783584: 0.1%
Covered Lines: 30102
Relevant Lines: 52496

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants