Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include MessageExtractor code in fulltext #86

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

giampaolo
Copy link
Contributor

@giampaolo giampaolo commented Jan 18, 2018

MsgExtractor lib is not easy to deal with in terms of packaging and as a dependency in general, see:

https://github.com/mattgwwalker/msg-extractor/issues/23
https://github.com/mattgwwalker/msg-extractor/issues/24
https://github.com/mattgwwalker/msg-extractor/issues/25

I even disabled travis CI for python 2.7 because it could not get installed:
2b01185

With this PR I just include it in fulltext code base. This will make builds faster as it's one less dep to retrieve from GIT (there's no MsgExtractor on PYPI).

@giampaolo giampaolo requested a review from btimby January 18, 2018 11:59
@btimby
Copy link
Owner

btimby commented Jan 18, 2018

Why not just fork and add to PyPI?

@giampaolo
Copy link
Contributor Author

I'm not the owner so I cannot register MsgExtractor on PYPI. I filed a couple of issues on MsgExtractor bug tracker asking if they're interested in packaging it properly and put it on PYPI (they are). I made an initial PR but it's not reviewed/merged yet. Basically we can't properly fix this until they push it forward.

@TheElementalOfDestruction

Have your issues been fixed in the most recent version of msg-extractor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants