Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The $border: variable to new file and position in compile list #267

Open
saucyrooster opened this issue May 19, 2023 · 0 comments
Open

The $border: variable to new file and position in compile list #267

saucyrooster opened this issue May 19, 2023 · 0 comments

Comments

@saucyrooster
Copy link
Contributor

Description

The $border variable located in foundation _config.scss settings should be moved to enable setting a global color based on the child theme.

Issue

By including the $border variable in the config settings we are declaring styles in a configuration file. Styles should not be included in any abstract files and only declare initial configurations. Currently the $border variable calls a color for the default configuration based on responsive-foundations inclusion of variables $color-grayscale-*.

Solution

Create and move the border variable declaration to a _base.scss partial and load after all abstract config files. ie

  1. _config.scss
  2. _vars.scss
  3. _colors.scss
  4. _functions.scss
  5. _mixins.scss
  6. _base.scss <-- $border: ;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant