-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show dialog when save fails to mount #137
Conversation
With the added version check, is there any situation where a save fails to mount and the user doesn't get a notification? |
Can you test the same save with the last official release? Just to confirm if it fails with the last 1.4.0 version or not. If not, then the newer SDK introduced issues |
1.4.0 release worked. SDK from April 2022 worked but not newest commit. |
then there's an issue with the new sdk version. Either a data type or structure has changed and is not matching the correct size/format , or some other change from the sdk has an issue. I'd say that actually this PR should either become a fix for the new SDK issue or goes back to the older sdk that keeps the save-mounting working. |
Yeah. I will look into the changes in the SDK. It will be better to fix the source of the issue |
Related to this, probably is better to go back to the old OO-SDK on github actions so any "nightly build" works properly. (until SDK bug gets solved) |
I forgot about this, just got my development environment setup, will check it sometime |
Reverted CI script back to older OO-SDK to avoid broken builds. |
No description provided.