Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show dialog when save fails to mount #137

Closed
wants to merge 1 commit into from

Conversation

illusion0001
Copy link
Contributor

No description provided.

@illusion0001 illusion0001 changed the title Snow dialog when save fails to mount Show dialog when save fails to mount Aug 22, 2023
@bucanero
Copy link
Owner

With the added version check, is there any situation where a save fails to mount and the user doesn't get a notification?

@illusion0001
Copy link
Contributor Author

When built using newest oosdk commit it failed to mount.
image

@bucanero
Copy link
Owner

Can you test the same save with the last official release? Just to confirm if it fails with the last 1.4.0 version or not. If not, then the newer SDK introduced issues

@illusion0001
Copy link
Contributor Author

1.4.0 release worked. SDK from April 2022 worked but not newest commit.

@bucanero
Copy link
Owner

1.4.0 release worked. SDK from April 2022 worked but not newest commit.

then there's an issue with the new sdk version. Either a data type or structure has changed and is not matching the correct size/format , or some other change from the sdk has an issue.

I'd say that actually this PR should either become a fix for the new SDK issue or goes back to the older sdk that keeps the save-mounting working.

@bucanero bucanero marked this pull request as draft August 24, 2023 22:18
@illusion0001
Copy link
Contributor Author

Yeah. I will look into the changes in the SDK. It will be better to fix the source of the issue

@bucanero
Copy link
Owner

Related to this, probably is better to go back to the old OO-SDK on github actions so any "nightly build" works properly. (until SDK bug gets solved)

@illusion0001
Copy link
Contributor Author

I forgot about this, just got my development environment setup, will check it sometime

@bucanero
Copy link
Owner

bucanero commented Dec 4, 2023

Reverted CI script back to older OO-SDK to avoid broken builds.

@bucanero bucanero closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants