Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BP-3290 Fix support for guzzlehttp v5 #159

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

vegimcarkaxhija
Copy link
Contributor

No description provided.

@avido
Copy link
Contributor

avido commented Dec 7, 2023

Why is v5 supported / needed?
V5 / v6 contains several security advisories ...

@ShuCh3n
Copy link
Contributor

ShuCh3n commented Dec 7, 2023

You're right about this. But unfortunately, we do need to provide support to some of our older plugins. Recently we refractor our Prestashop plugin using this SDK. Prestashop 1.7.0 still uses Guzzle v5. Therefore we decided to also make it work for Guzzle v5.

https://devdocs.prestashop-project.org/8/modules/creation/external-services/#requests-from-a-shop

@Buckaroo-Rene Buckaroo-Rene changed the title Add support for guzzlehttp v5 BP-3290 Add support for guzzlehttp v5 Dec 18, 2023
@vegimcarkaxhija vegimcarkaxhija merged commit f270a86 into develop Dec 18, 2023
5 checks passed
@vegimcarkaxhija vegimcarkaxhija deleted the add-support-for-guzzlehttp-v5 branch December 18, 2023 14:20
@Buckaroo-Rene Buckaroo-Rene changed the title BP-3290 Add support for guzzlehttp v5 BP-3290 Fix support for guzzlehttp v5 Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants