PROD-7208 - GIFS search is not working on multi-level comments #4403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jitendrabanjara1991
previously approved these changes
May 11, 2024
…i in activity modal
* release: (131 commits) Update: Grunt Update: Grunt string-replace Update: Version name update grunt Added change log pulled api changes PROD-7433 - Typo fixed PROD-7433 - Grunt PROD-7433 - Update schedule allowed value null to disabled. Fixed - When setting disable, In feed - select group and add content and keep data as draft. Once you open draft feed again the scheduled icon still was there. PROD-7433 - Only validate for schedule post PROD-7433 - Allow read more for schedule post PROD-7433 - Fixed - Check for non admin member to delete scheduled post which they scheduled when they have permission to moderate. PROD-7433 - Remove error log PROD-7433 - Fixed - delete scheduled activity issue for group PROD-7433 - Code refactor and run grunt PROD-7433 - Fixed - undefined error PROD-7433 - Fixed - validate delete schedule post for group. - Like some one has org/mode and they added schedule post but after some time they change role from org to member, not they try to delete schedule post then they not allow to delete PROD-7433 - Fixed - Schedule button icon issue PROD-7433 - Read more content issue PROD-7433 - Code refactor - Allow hide/show schedule form for admin/group organiser. If loggedin with admin and setting disable then schedule icon should be visible for admin - If non admin user, setting is enable for schedule button, and in news feed page, he select some group where they have org/mode, then schedule icon should be visible ... # Conflicts: # src/bp-templates/bp-nouveau/js/buddypress-activity.min.js # src/bp-templates/bp-nouveau/js/buddypress-nouveau.min.js
jitendrabanjara1991
previously approved these changes
May 23, 2024
* release: PROD-6756 - Update doc block comment and fixed js code beautifier PROD-6756 - fix: Added condition before localize script and properly type, value check for global var in js PROD-6756 - fix: Added param in localize script and set condition based on it into js PROD-6756 - fix: Changed dropzone preview thumb url # Conflicts: # src/bp-templates/bp-nouveau/js/buddypress-activity.min.js # src/bp-templates/bp-nouveau/js/buddypress-media.min.js # src/bp-templates/bp-nouveau/js/buddypress-nouveau.min.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue:
https://buddyboss.atlassian.net/browse/PROD-7208
General Note
Keep all conversations related to this PR in the associated Jira issue(s). Do NOT add comment on this PR or edit this PR’s description.
Notes to Developer
Notes to Reviewer