PROD-8099 #4530
Open
PROD-8099 #4530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated admin settings to conditionally display member counts based on the user's preference. - Prevented passing count data in AJAX requests when the count setting is disabled.
…ack args as not required - remove callback args as not required for User Count
…tory count option for existing installations.
…is is also consider as directory. - Also, "groups_total_groups_for_user( bp_displayed_user_id() )" remove this one because count is getting using this function "bb_group_directory_count_enable"
- Hide count for subgroups when 'Group Count' is disable
…. Its reflect in the API for group details
| // Add 'Connections' to the main navigation. | ||
| $count = friends_get_total_friend_count(); | ||
| $class = ( 0 === $count ) ? 'no-count' : 'count'; | ||
| $enable_count = bb_member_directory_count_enable(); |
There was a problem hiding this comment.
@yudhisthirnahar
Remove this, as it is not used anywhere in this function
Comment on lines
132
to
133
| $atts = apply_filters( 'bp_learndash_user_courses_atts', array() ); | ||
| $user_courses = apply_filters( 'bp_learndash_user_courses', ld_get_mycourses( $this->bp_displayed_user_id, $atts ) ); |
There was a problem hiding this comment.
@yudhisthirnahar
After making the new changes, it is no longer used in this function, so please remove it.
| * | ||
| * @return int album count of the user. | ||
| */ | ||
| function bp_media_get_total_album_count() { |
There was a problem hiding this comment.
Suggested change
| function bp_media_get_total_album_count() { | |
| function bb_media_get_total_album_count() { |
Comment on lines
+860
to
+867
| /** | ||
| * Filters the total media count for a given user. | ||
| * | ||
| * @param int $count Total media count for a given user. | ||
| * | ||
| * @since BuddyBoss 1.0.0 | ||
| */ | ||
| return apply_filters( 'bp_media_get_total_album_count', (int) $count ); |
There was a problem hiding this comment.
Suggested change
| /** | |
| * Filters the total media count for a given user. | |
| * | |
| * @param int $count Total media count for a given user. | |
| * | |
| * @since BuddyBoss 1.0.0 | |
| */ | |
| return apply_filters( 'bp_media_get_total_album_count', (int) $count ); | |
| /** | |
| * Filters the total media count for a given user. | |
| * | |
| * @since BuddyBoss [BBVERSION] | |
| * | |
| * @param int $count Total media count for a given user. | |
| */ | |
| return apply_filters( 'bb_media_get_total_album_count', (int) $count ); |
| }, 0 ); | ||
| add_action( | ||
| 'admin_init', | ||
| function() { |
There was a problem hiding this comment.
Suggested change
| function() { | |
| function () { |
Comment on lines
+206
to
+207
| 'singular' => esc_html( 'Album', 'buddyboss' ), | ||
| 'plural' => esc_html( 'Albums', 'buddyboss' ), |
There was a problem hiding this comment.
Suggested change
| 'singular' => esc_html( 'Album', 'buddyboss' ), | |
| 'plural' => esc_html( 'Albums', 'buddyboss' ), | |
| 'singular' => esc_html__( 'Album', 'buddyboss' ), | |
| 'plural' => esc_html__( 'Albums', 'buddyboss' ), |
Comment on lines
+210
to
+211
| 'singular' => esc_html( 'Photo', 'buddyboss' ), | ||
| 'plural' => esc_html( 'Photos', 'buddyboss' ), |
There was a problem hiding this comment.
Suggested change
| 'singular' => esc_html( 'Photo', 'buddyboss' ), | |
| 'plural' => esc_html( 'Photos', 'buddyboss' ), | |
| 'singular' => esc_html__( 'Photo', 'buddyboss' ), | |
| 'plural' => esc_html__( 'Photos', 'buddyboss' ), |
| @@ -17,16 +17,17 @@ | |||
| * @return array An associative array of nav items. | |||
| */ | |||
| function bp_nouveau_get_members_directory_nav_items() { | |||
| $nav_items = array(); | |||
| $enable_count = bb_member_directory_count_enable(); | |||
There was a problem hiding this comment.
@yudhisthirnahar
Remove this, as it is not used anywhere in this function.
| dir_count = response.data.media_all_count; | ||
| } else if ( 'personal' === dir_scope ) { | ||
| dir_count = response.data.media_personal_count; | ||
| } else if( 'groups' === dir_scope ) { |
There was a problem hiding this comment.
Suggested change
| } else if( 'groups' === dir_scope ) { | |
| } else if ( 'groups' === dir_scope ) { |
| dir_count = response.data.video_all_count; | ||
| } else if ( 'personal' === dir_scope ) { | ||
| dir_count = response.data.video_personal_count; | ||
| } else if( 'groups' === dir_scope ) { |
There was a problem hiding this comment.
Suggested change
| } else if( 'groups' === dir_scope ) { | |
| } else if ( 'groups' === dir_scope ) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue:
https://buddyboss.atlassian.net/browse/PROD-8052
https://buddyboss.atlassian.net/browse/PROD-8099
General Note
Keep all conversations related to this PR in the associated Jira issue(s). Do NOT add comment on this PR or edit this PR’s description.
Notes to Developer
Notes to Reviewer