Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compose: mariadb -> service_healthy #128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

grooverdan
Copy link

Details

MARIADB_ALLOW_EMPTY_PASSWORD isn't a variable recognised by the MariaDB container, and MARIADB_ALLOW_EMPTY_ROOT_PASSWORD is a bit false when we set a password.

Also use MariaDB's healthcheck script to ensure the service is healthy before running tests. There is other mechanisms to enforce this, but lets be clear at the basic level of the healthcheck.sh script maintained in the container (currently by me).

Additional info

Test Plan

  1. Look at mariadb in github actions test run

MARIADB_ALLOW_EMPTY_PASSWORD isn't a variable recognised by
the MariaDB container, and MARIADB_ALLOW_EMPTY_ROOT_PASSWORD is
a bit false when we set a password.

Also use MariaDB's healthcheck script to ensure the service is
healthy before running tests. There is other mechanisms to
enforce this, but lets be clear at the basic level of the healthcheck.sh
script maintained in the container (currently by me).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant