Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unity-setup@v1.0.6 #7

Merged
merged 12 commits into from
Aug 10, 2024
Merged

unity-setup@v1.0.6 #7

merged 12 commits into from
Aug 10, 2024

Conversation

StephenHodgson
Copy link
Member

@StephenHodgson StephenHodgson commented Aug 8, 2024

  • improved version-file search, and added None option when creating new projects or setting UNITY_PROJECT_PATH later

@StephenHodgson StephenHodgson marked this pull request as ready for review August 10, 2024 02:45
@StephenHodgson StephenHodgson requested a review from a team as a code owner August 10, 2024 02:45
@@ -51,7 +51,7 @@ steps:

| name | description | required |
| ----------- | ----------- | ----------- |
| `version-file` | Specify a path to search for the unity project version text file. Useful if there are multiple projects in a single repo. | false |
| `version-file` | Specify a path to search for the unity project version text file. Useful if there are multiple projects in a single repo. Pass `None` if creating a new project to skip file search. | false |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this description I don't understand when I would use 'None'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When creating a new project or skipping the file search option.

README.md Show resolved Hide resolved
Copy link

@afarchy afarchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine but see comments

@StephenHodgson StephenHodgson merged commit 02e3ad9 into main Aug 10, 2024
24 checks passed
@StephenHodgson StephenHodgson deleted the development branch August 10, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants