Add mount functionality to 'Directory' #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stagnation
commented
Sep 6, 2023
stagnation
force-pushed
the
feature/mount-special-filesystems-in-chroot-runners
branch
from
ac05320
to
03950d3
Compare
stagnation
commented
Sep 6, 2023
EdSchouten
reviewed
Sep 6, 2023
pkg/filesystem/mount_unix.go
Outdated
| _p1 = nil | ||
| } | ||
|
|
||
| r0, _, e1 := unix.Syscall6( |
There was a problem hiding this comment.
The same holds for fsconfig(). We could also let golang.org/x/sys/unix ship with a binding for that. My experience is that the folks maintaining that package are willing to accept such changes. They also review them in a timely manner.
There was a problem hiding this comment.
I have updated the commit with the patch file, and will wait a couple more days for them to see my comment on the original review before forking it.
There was a problem hiding this comment.
Pushed a new patch, with the new proposed API.
There was a problem hiding this comment.
There has not been any progress on the review since we last discussed the patch :/
golang/go#59537 (comment)
stagnation
force-pushed
the
feature/mount-special-filesystems-in-chroot-runners
branch
from
03950d3
to
b29adf9
Compare
EdSchouten
reviewed
Sep 6, 2023
stagnation
force-pushed
the
feature/mount-special-filesystems-in-chroot-runners
branch
from
b29adf9
to
772956f
Compare
stagnation
force-pushed
the
feature/mount-special-filesystems-in-chroot-runners
branch
from
772956f
to
4269bbc
Compare
EdSchouten
reviewed
Sep 16, 2023
stagnation
force-pushed
the
feature/mount-special-filesystems-in-chroot-runners
branch
3 times, most recently
from
58135c0
to
02a95a4
Compare
stagnation
force-pushed
the
feature/mount-special-filesystems-in-chroot-runners
branch
from
02a95a4
to
0af1b16
Compare
stagnation
force-pushed
the
feature/mount-special-filesystems-in-chroot-runners
branch
from
0af1b16
to
c822402
Compare
stagnation
force-pushed
the
feature/mount-special-filesystems-in-chroot-runners
branch
from
c822402
to
857e0a7
Compare
EdSchouten
approved these changes
Dec 12, 2023
stagnation
force-pushed
the
feature/mount-special-filesystems-in-chroot-runners
branch
from
857e0a7
to
646f697
Compare
|
Applied the last review comments :) |
EdSchouten
approved these changes
Dec 20, 2023
This is needed for 'chroot' runners that must mount the special filesystems '/proc' and '/sys' in the input root. The necessary syscalls are not yet merged into the 'sys' package, so this includes a patch while we work to upstream the code.
stagnation
force-pushed
the
feature/mount-special-filesystems-in-chroot-runners
branch
from
646f697
to
7aef0b0
Compare
stagnation
deleted the
feature/mount-special-filesystems-in-chroot-runners
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for 'chroot' runners that must mount the special filesystems '/proc' and '/sys' in the input root.
buildbarn/bb-remote-execution#115