Feature/upgrade gazelle #184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a fix to issue 1595 so we no longer need that patch.
This should solve bzlmod issues along the following lines:
$ bazel build //:gazelle
ERROR: /.../external/bazel_gazelle_go_repository_config/BUILD.bazel: no such
target '@@bazel_gazelle_go_repository_config//:WORKSPACE': target 'WORKSPACE'
not declared in package '' defined by
/.../external/bazel_gazelle_go_repository_config/BUILD.bazel;
however, a source file of this name exists. (Perhaps add
'exports_files(["WORKSPACE"])' to /BUILD?)
EdSchouten
approved these changes
Dec 20, 2023
| @@ -20,16 +20,16 @@ index 0b23cca..c532ad2 100644 | |||
| return goBinary | |||
There was a problem hiding this comment.
Good news is that at some point in the future we may remove this patch:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.