Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/freshen up widows filesystem #188

Closed
wants to merge 8 commits into from
Closed

Feature/freshen up widows filesystem #188

wants to merge 8 commits into from

Commits on Feb 7, 2024

  1. Fix typos

    Nils Wireklint authored and Nils Wireklint committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    55c296a View commit details
    Browse the repository at this point in the history

  2. Improve errors

    Nils Wireklint authored and Nils Wireklint committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    e299123 View commit details
    Browse the repository at this point in the history

  3. Update 'aspect_rules_js' 

    This is required to build the otel stylesheet on Windows.
    Nils Wireklint authored and Nils Wireklint committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    9de9f10 View commit details
    Browse the repository at this point in the history

  4. Explicitly request query label output 

    To work with users who prefer a different output in their personal rc
file. Using '--nohome_rc' is not good either, if they want to change the
output base this query would duplicate a lot of data.
    Nils Wireklint authored and Nils Wireklint committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    0beee53 View commit details
    Browse the repository at this point in the history

  5. Improve absolute path handling on Windows 

    In the presence of forward-slash paths with drive letters.
They can come from environment variable expansion in the proto
configuration.
    Nils Wireklint authored and Nils Wireklint committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    ec981ba View commit details
    Browse the repository at this point in the history

  6. Windows: Fix 'readdirnames': fetch all the directory entries. 

    The 'ERROR_MORE_DATA' error is never raised so this continues parsing
until the bookend 'ERROR_NO_MORE_DATA' is raised instead.
    Nils Wireklint authored and Nils Wireklint committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    fa2041e View commit details
    Browse the repository at this point in the history

  7. Windows: Close handles - to avoid hardlink exhaustion

    Nils Wireklint authored and Nils Wireklint committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    ef37b8a View commit details
    Browse the repository at this point in the history

  8. Windows: hardlinks do not need write permission 

    This fixes execution errors where some programs fail to execute while a
source file is hardlinked into another scheduled actions. Many compilers
restrict the sharing mode for the files they open, 'cl.exe' for instance
does not allow other processes to have open WRITE handles to its source
files, and fails with SHARING_VIOLATION if such handles are open. The
hardlinking file fetcher does not need this permission and we solve many
crashes by removing it.
    Nils Wireklint authored and Nils Wireklint committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    97ec1e5 View commit details
    Browse the repository at this point in the history