LocalBlobAccess: Double the recommended number of attempts #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moroten
suggested changes
Sep 10, 2024
EdSchouten
force-pushed
the
eschouten/20240910-bump-attempts
branch
from
2cb5259
to
49bb21d
Compare
moroten
suggested changes
Sep 10, 2024
| keyLocationMapMaximumGetAttempts: 8, | ||
| keyLocationMapMaximumPutAttempts: 32, | ||
| keyLocationMapMaximumGetAttempts: 16, | ||
| keyLocationMapMaximumPutAttempts: 64, |
There was a problem hiding this comment.
Line 63-64 also need an update.
Right now we set the maximum get attempts to just eight. This might be a bit too tight, requiring users to create KeyLocationMaps that are unnecessarily big. Given that nobody has really complained about these values being too large, let's bump them.
EdSchouten
force-pushed
the
eschouten/20240910-bump-attempts
branch
from
49bb21d
to
d569839
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we set the maximum get attempts to just eight. This might be a bit too tight, requiring users to create KeyLocationMaps that are unnecessarily big. Given that nobody has really complained about these values being too large, let's bump them.