Revert "nogo: enable SA1024" (#6296)

buildbuddy-io · Apr 3, 2024 · 8621934 · 8621934
1 parent 8510346
commit 8621934
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/BUILD b/BUILD
@@ -127,6 +127,7 @@ nogo(
         "@com_github_nishanths_exhaustive//:exhaustive",
     ] + staticcheck_analyzers(ANALYZERS + [
         "-SA1019",
+        "-SA1024",
         "-SA1029",
         "-SA9001",
         "-ST1000",

diff --git a/server/xcode/xcode_darwin.go b/server/xcode/xcode_darwin.go
@@ -107,7 +107,7 @@ func versionMap(urlRefs []C.CFURLRef) map[string]*xcodeVersion {
 	defaultDeveloperDir := xcodeSelectDeveloperDir()
 	versionMap := make(map[string]*xcodeVersion)
 	for _, urlRef := range urlRefs {
-		path := "/" + strings.TrimPrefix(stringFromCFString(C.CFURLGetString(C.CFURLRef(urlRef))), filePrefix)
+		path := "/" + strings.TrimLeft(stringFromCFString(C.CFURLGetString(C.CFURLRef(urlRef))), filePrefix)
 		xcodePlist, err := xcodePlistForPath(path + versionPlistPath)
 		if err != nil {
 			log.Warningf("Error reading plist for Xcode: %s", err.Error())