Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extraVolumeMounts with podSpecPatch #327

Open
bpoland opened this issue May 16, 2024 · 1 comment
Open

Allow extraVolumeMounts with podSpecPatch #327

bpoland opened this issue May 16, 2024 · 1 comment

Comments

@bpoland
Copy link

bpoland commented May 16, 2024

👋 with the podSpecPatch functionality introduced in #282 I'd really like to be able to specify default volumes to mount to all containers (e.g. the extraVolumeMounts available without the patching. Is this something that could be added? Maybe an extra-volume-mounts to define in the controller helm values?

I want to use this to mount an agent hooks volume as well as pipeline signing keys. Thanks!

@moskyb
Copy link
Contributor

moskyb commented May 22, 2024

kia ora @bpoland! this would be a useful feature to have in the k8s stack, and we'll it to our backlog. in the meantime, we would happily accept PRs to this effect. if you want to reach out to me or @DrJosh9000 on slack, we can potentially help you out with implementation stuff, if you're interested.

@bpoland bpoland changed the title Allow more flexibility with podSpecPatch Allow extraVolumeMounts with podSpecPatch May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants