Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update] Updating agentTokenCreate mutation to use new tokenValue. #2281

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

CheeseStick
Copy link
Contributor

Context

With a recent security update from Buildkite, the token field in agentTokenEdge is deprecated but is now changed to tokenValue to retrieve the token when creating one through agentTokenCreate mutation.

This PR

  • Updates the buildkite-agent v3 documentation to use updated GraphQL API when creating agent token

@mbelton-buildkite
Copy link
Contributor

Thanks for catching this and fixing it, @CheeseStick! I'll get someone from Buildkite to provide a technical review, then I'll run the linting and merge for you. 😊

Copy link
Contributor

@jradtilbrook jradtilbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this is correct. We are using this in terraform and you can see our valid working query here: https://github.com/buildkite/terraform-provider-buildkite/blob/main/buildkite/graphql/agent_token.graphql#L21

@mbelton-buildkite you should be good to proceed with this PR

Copy link
Contributor

@mbelton-buildkite mbelton-buildkite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @CheeseStick! And thanks @jradtilbrook. The linting has passed, so I'll merge this for you and it should be live soon. 😊

@mbelton-buildkite mbelton-buildkite merged commit 4ce2d60 into buildkite:main Jul 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants